You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/12 22:52:07 UTC
Review Request 55473: Marked a member function `const`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55473/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
Marked a member function `const`.
Diffs
-----
src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
Diff: https://reviews.apache.org/r/55473/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55473: Marked a member function `const`.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55473/#review162308
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp (lines 8758 - 8760)
<https://reviews.apache.org/r/55473/#comment233640>
keep it on one line.
- Vinod Kone
On Jan. 12, 2017, 10:52 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55473/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 10:52 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6619
> https://issues.apache.org/jira/browse/MESOS-6619
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked a member function `const`.
>
>
> Diffs
> -----
>
> src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
> src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
>
> Diff: https://reviews.apache.org/r/55473/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55473: Marked a member function `const`.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55473/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 4:57 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Whitespace fix.
Bugs: MESOS-6619
https://issues.apache.org/jira/browse/MESOS-6619
Repository: mesos
Description
-------
Marked a member function `const`.
Diffs (updated)
-----
src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55473/diff/
Testing
-------
`make check`
Thanks,
Neil Conway