You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/04 19:25:11 UTC
[GitHub] [geode] mhansonp opened a new pull request #6091: GEODE-8886: upgradeTest sometimes fails with new test
mhansonp opened a new pull request #6091:
URL: https://github.com/apache/geode/pull/6091
Reverting my test out due to presumed interactions with tests in the test class. Working on fixing and re-adding at a later date
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mhansonp merged pull request #6091: GEODE-8886: upgradeTest sometimes fails with new test
Posted by GitBox <gi...@apache.org>.
mhansonp merged pull request #6091:
URL: https://github.com/apache/geode/pull/6091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mhansonp commented on a change in pull request #6091: GEODE-8886: upgradeTest sometimes fails with new test
Posted by GitBox <gi...@apache.org>.
mhansonp commented on a change in pull request #6091:
URL: https://github.com/apache/geode/pull/6091#discussion_r587935287
##########
File path: geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewaySenderProfile.java
##########
@@ -23,23 +23,25 @@
import org.apache.geode.distributed.internal.InternalLocator;
import org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue;
import org.apache.geode.test.dunit.DistributedTestUtils;
+import org.apache.geode.test.dunit.Host;
import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.NetworkUtils;
import org.apache.geode.test.dunit.VM;
import org.apache.geode.test.version.VersionManager;
public class WANRollingUpgradeVerifyGatewaySenderProfile extends WANRollingUpgradeDUnitTest {
@Test
-
- // This test verifies that a GatewaySenderProfile serializes properly between versions.
+ // Thigit s test verifies that a GatewaySenderProfile serializes properly between versions.
Review comment:
Yup, but I am not inclined to fix it now. I will fix it when I check the test back in...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou commented on a change in pull request #6091: GEODE-8886: upgradeTest sometimes fails with new test
Posted by GitBox <gi...@apache.org>.
gesterzhou commented on a change in pull request #6091:
URL: https://github.com/apache/geode/pull/6091#discussion_r587862139
##########
File path: geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewaySenderProfile.java
##########
@@ -23,23 +23,25 @@
import org.apache.geode.distributed.internal.InternalLocator;
import org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue;
import org.apache.geode.test.dunit.DistributedTestUtils;
+import org.apache.geode.test.dunit.Host;
import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.NetworkUtils;
import org.apache.geode.test.dunit.VM;
import org.apache.geode.test.version.VersionManager;
public class WANRollingUpgradeVerifyGatewaySenderProfile extends WANRollingUpgradeDUnitTest {
@Test
-
- // This test verifies that a GatewaySenderProfile serializes properly between versions.
+ // Thigit s test verifies that a GatewaySenderProfile serializes properly between versions.
Review comment:
typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mhansonp commented on a change in pull request #6091: GEODE-8886: upgradeTest sometimes fails with new test
Posted by GitBox <gi...@apache.org>.
mhansonp commented on a change in pull request #6091:
URL: https://github.com/apache/geode/pull/6091#discussion_r587935362
##########
File path: geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewaySenderProfile.java
##########
@@ -23,23 +23,25 @@
import org.apache.geode.distributed.internal.InternalLocator;
import org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue;
import org.apache.geode.test.dunit.DistributedTestUtils;
+import org.apache.geode.test.dunit.Host;
import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.NetworkUtils;
import org.apache.geode.test.dunit.VM;
import org.apache.geode.test.version.VersionManager;
public class WANRollingUpgradeVerifyGatewaySenderProfile extends WANRollingUpgradeDUnitTest {
@Test
-
- // This test verifies that a GatewaySenderProfile serializes properly between versions.
+ // Thigit s test verifies that a GatewaySenderProfile serializes properly between versions.
Review comment:
Hopefully that is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org