You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/08/30 18:26:19 UTC
[GitHub] [lucene] MarcusSorealheis opened a new pull request, #11731: 11730 removed unused fst load mode
MarcusSorealheis opened a new pull request, #11731:
URL: https://github.com/apache/lucene/pull/11731
### Description
This pull request removes the `ON_HEAP` load mode for finite state machines. If FSTs are not MMAPped, they are read from disk using NIO FS. I did not see a way to force `ON_HEAP`. Perhaps we should remove it.
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on PR #11731:
URL: https://github.com/apache/lucene/pull/11731#issuecomment-1232250879
Ok, so I did identify how an advanced user can still get FSTs to be loaded in heap (via service provider initialization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis closed pull request #11731: 11730 removed unused fst load mode
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis closed pull request #11731: 11730 removed unused fst load mode
URL: https://github.com/apache/lucene/pull/11731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on PR #11731:
URL: https://github.com/apache/lucene/pull/11731#issuecomment-1232014930
It's linked to this issue: https://github.com/apache/lucene/issues/11730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on PR #11731:
URL: https://github.com/apache/lucene/pull/11731#issuecomment-1242990444
@jpountz It makes sense to close the PR It's very dirty.
Can you link me to the discussion? I remember [LUCENE-8859](https://github.com/apache/lucene/issues/9902) but haven't seen/couldn't find something more recent.
I am really excited about the Git migration. I think it will feel even nicer in the future once i get used to information discovery here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] MarcusSorealheis commented on pull request #11731: 11730 removed unused fst load mode
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on PR #11731:
URL: https://github.com/apache/lucene/pull/11731#issuecomment-1232015684
The MLT commit did not belong in the working tree. I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #11731: 11730 removed unused fst load mode
Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #11731:
URL: https://github.com/apache/lucene/pull/11731#issuecomment-1240744318
Changing the default for the completion postings format might be controversial. Maybe we should close this PR since we're still using the ON_HEAP mode and have a separate discussion about whether completion postings formats could move to OFF_HEAP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org