You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 17:40:12 UTC

[GitHub] [spark] jiangxb1987 commented on a change in pull request #26306: [SPARK-29646][BUILD] Allow pyspark version name format `${versionNumber}-preview` in release script

jiangxb1987 commented on a change in pull request #26306: [SPARK-29646][BUILD] Allow pyspark version name format `${versionNumber}-preview` in release script
URL: https://github.com/apache/spark/pull/26306#discussion_r340763759
 
 

 ##########
 File path: dev/create-release/release-build.sh
 ##########
 @@ -219,7 +219,7 @@ if [[ "$1" == "package" ]]; then
 
     # Write out the VERSION to PySpark version info we rewrite the - into a . and SNAPSHOT
     # to dev0 to be closer to PEP440.
-    PYSPARK_VERSION=`echo "$SPARK_VERSION" |  sed -r "s/-/./" | sed -r "s/SNAPSHOT/dev0/"`
+    PYSPARK_VERSION=`echo "$SPARK_VERSION" |  sed -r "s/-/./" | sed -r "s/SNAPSHOT/dev0/" | sed -r "s/preview/dev0/"`
 
 Review comment:
   IIUC it would be `pyspark-3.0.0.dev0.tar.gz` which is expected ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org