[GitHub] [spark] rangadi commented on a diff in pull request #40966: [SPARK-43206] [SS] [CONNECT] StreamingQuery exception() include stack trace

["rangadi (via GitHub)" <gi...@apache.org>]

rangadi commented on code in PR #40966:
URL: https://github.com/apache/spark/pull/40966#discussion_r1181878060


##########
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala:
##########
@@ -408,15 +408,15 @@ class StreamingQueryManager private[sql] (
       query.streamingQuery.start()
     } catch {
       case e: Throwable =>
-        unregisterTerminatedStream(query)
+//        unregisterTerminatedStream(query)
         throw e
     }
     query
   }
 
   /** Notify (by the StreamingQuery) that the query has been terminated */
   private[sql] def notifyQueryTermination(terminatedQuery: StreamingQuery): Unit = {
-    unregisterTerminatedStream(terminatedQuery)
+//    unregisterTerminatedStream(terminatedQuery)

Review Comment:
   @WweiL is this by mistake? Should we revert this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org