You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Tim Ellison (JIRA)" <de...@geronimo.apache.org> on 2005/04/29 13:10:06 UTC
[jira] Created: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Remove dependency on Sun internals code for URL decoding
--------------------------------------------------------
Key: GERONIMO-640
URL: http://issues.apache.org/jira/browse/GERONIMO-640
Project: Geronimo
Type: Improvement
Versions: 1.0-M3
Reporter: Tim Ellison
[Looking at 1.0-M3 source code]
The Geronimo types:
org.apache.geronimo.system.url.file.Handler
and
org.apache.geronimo.system.url.file.FileURLConnection
both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Tim Ellison (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=comments#action_64068 ]
Tim Ellison commented on GERONIMO-640:
--------------------------------------
Yep, that would likely work just as well / better.
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=all ]
Dain Sundstrom reassigned GERONIMO-640:
---------------------------------------
Assign To: Dain Sundstrom (was: Alan Cabrera)
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Assignee: Dain Sundstrom
> Fix For: 1.0
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Alan Cabrera (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=all ]
Alan Cabrera reassigned GERONIMO-640:
-------------------------------------
Assign To: Alan Cabrera
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Assignee: Alan Cabrera
> Fix For: 1.0-M5
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=comments#action_12317610 ]
Rick McGuire commented on GERONIMO-640:
---------------------------------------
Aaron, I had some discussions about FileURLConnection last week with David Blevins and David Jencks on another issue, and we came to the conclusion that the support this class offers over and above the default file connection protocol was not being used be Geronimo. I've been doing some build and test experiments with this this class removed over the last couple of days and this does appear to be true. If this class really needs repairing, then a better solution would probably be to get rid of it entirely.
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Fix For: 1.0-M5
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Jeremy Boynes (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=comments#action_64065 ]
Jeremy Boynes commented on GERONIMO-640:
----------------------------------------
Thanks for the patch
I'm curious though what this class is doing - wouldn't it now be sufficient to convert the URL to a File using
File file = new File(new URI(url.toString());
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "David Blevins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=all ]
David Blevins updated GERONIMO-640:
-----------------------------------
Fix Version: 1.0
(was: 1.0-M5)
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Assignee: Alan Cabrera
> Fix For: 1.0
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=all ]
Aaron Mulder updated GERONIMO-640:
----------------------------------
Fix Version: 1.0-M5
Description:
[Looking at 1.0-M3 source code]
The Geronimo types:
org.apache.geronimo.system.url.file.Handler
and
org.apache.geronimo.system.url.file.FileURLConnection
both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
was:
[Looking at 1.0-M3 source code]
The Geronimo types:
org.apache.geronimo.system.url.file.Handler
and
org.apache.geronimo.system.url.file.FileURLConnection
both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
Environment:
Still a problem for M4 and HEAD as of today
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Fix For: 1.0-M5
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Tim Ellison (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=all ]
Tim Ellison updated GERONIMO-640:
---------------------------------
Attachment: decode-patch.txt
Suggested patch to resolve JRE impl. dependency.
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-640?page=all ]
Dain Sundstrom closed GERONIMO-640:
-----------------------------------
Resolution: Invalid
This patch is no longer needed. The patched files were removed a wile ago.
> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
> Key: GERONIMO-640
> URL: http://issues.apache.org/jira/browse/GERONIMO-640
> Project: Geronimo
> Type: Improvement
> Versions: 1.0-M3
> Reporter: Tim Ellison
> Assignee: Dain Sundstrom
> Fix For: 1.0
> Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
> org.apache.geronimo.system.url.file.Handler
> and
> org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil". It appears that the usage is quite trivial, and can easily be replaced by API calls on URLDecoder. This will remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil, so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to "a b" whereas ParseUtil leaves it as "a+b". Is this difference in decoding behavior expected by Geronimo?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira