You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/25 07:40:29 UTC

[GitHub] [cloudstack] utchoang opened a new pull request #4764: UI: Fix create zone wizard on mobile view

utchoang opened a new pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764


   ### Description
   This PR for fixes create zone form in mobile view
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   After fixed:
   ![image](https://user-images.githubusercontent.com/13766648/110285298-9f499400-8015-11eb-9d3f-855541568a25.png)![image](https://user-images.githubusercontent.com/13766648/110285337-b2f4fa80-8015-11eb-9ee6-5c624f4225c4.png)
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-792522511


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4764 (JID-3852)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-805554998


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang closed pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
utchoang closed pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-805604152


   Will review after https://github.com/apache/cloudstack/pull/4764 since it has a shared commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-805555523


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-809281161


   @utchoang can you fix the conflict against latest 4.15 branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-806441075


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-806414370


   @utchoang Could you remove https://github.com/apache/cloudstack/pull/4764/commits/d998f2709f1cf1ea5fa957e0b90dfff1b46c17f9 and push ? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on pull request #4764: Feature/create zone mobile view

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-792519079


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-806443351


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4764 (SL-JID-71)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-805561560


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4764 (SL-JID-55)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-806440896


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani edited a comment on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-805604152


   Will review after https://github.com/apache/cloudstack/pull/4762 since it has a shared commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4764: UI: Fix create zone wizard on mobile view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4764:
URL: https://github.com/apache/cloudstack/pull/4764#issuecomment-792519582


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org