You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rusher (via GitHub)" <gi...@apache.org> on 2026/01/05 16:50:09 UTC
[PR] Add MariaDB support to Breeze development environment [airflow]
rusher opened a new pull request, #60133:
URL: https://github.com/apache/airflow/pull/60133
This doesn't add a specific mariadb Dialect, just permit easy testing.
to test, in place of setting mysql version, like '8.4', just set 'mariadb:11.8' for example. example :
breeze --backend mysql --mysql-version mariadb:11.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3899695401
> Could someone please enable CI workflows? Just to understand the scope of changes that the new backend will need and to present them on devlist.
Oh, yeah they are usually only enabled _after_ the first PR has been merged...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4055655479
@rusher This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :x: **Merge conflicts**: This PR has merge conflicts with the `main` branch. Your branch is 558 commits behind `main`. Please rebase your branch (`git fetch origin && git rebase origin/main`), resolve the conflicts, and push again. See [contributing quick start](https://github.com/apache/airflow/blob/main/contributing-docs/03a_contributors_quick_start_beginners.rst).
- :x: **Pre-commit / static checks**: Failing: CI image checks / Static checks. Run `prek run --from-ref main` locally to find and fix issues. See [Pre-commit / static checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst).
- :x: **mypy (type checking)**: Failing: CI image checks / MyPy checks (mypy-providers). Run `prek --stage manual mypy-providers --all-files` locally to reproduce. You need `breeze ci-image build --python 3.10` for Docker-based mypy. See [mypy (type checking) docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#mypy-checks).
- :x: **Build docs**: Failing: CI image checks / Build documentation (--docs-only). Run `breeze build-docs` locally to reproduce. See [Build docs docs](https://github.com/apache/airflow/blob/main/contributing-docs/16_documentation.rst).
- :x: **Other failing CI checks**: Failing: CI image checks / Build documentation (--spellcheck-only). Run `prek run --from-ref main` locally to reproduce. See [static checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst).
> **Note:** Your branch is **558 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.
**What to do next:**
- The comment informs you what you need to do.
- Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
- Maintainers will then proceed with a normal review.
Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4195104119
> So my best guess (but again - you MUST start devlist discussion if you want to support it) you will have to show exactly what kind of changes are necessary to support MariaDB in order to even begin a discussion "should we merge it". Which basically means that you will have to heave the PR green, when running it with your changes and have all the tests passing.
I just want to remind you that this is a MUST. And you have not started the discussion yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4297430150
@rusher This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
**Issues found:**
- :x: **Failing CI**: `Regular e2e test` (PROD image) and the top-level `Agent` status check are failing. Review the job logs to see which e2e scenarios regressed.
- :x: **Unresolved review comments** (7 threads): please walk through each unresolved review thread. **Even if a suggestion looks incorrect or irrelevant** — and some of them will be, especially any comments left by automated reviewers like GitHub Copilot — it is still the author's responsibility to respond: apply the fix, reply in-thread with a brief explanation of why the suggestion does not apply, or resolve the thread if the feedback is no longer relevant. Leaving threads unaddressed for weeks blocks the PR from moving forward.
**What to do next:**
- Walk through each unresolved review thread and respond as described above.
- Run the failing tests locally and push fixes.
- Make sure static checks pass locally: `prek run --from-ref main --stage pre-commit`.
- Mark the PR as "Ready for review" when you're done.
Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4300309676
Quick follow-up to the triage comment above — one clarification on the "Unresolved review comments" item:
Once you believe a thread has been addressed — whether by pushing a fix, or by replying in-thread with an explanation of why the suggestion doesn't apply — **please mark the thread as resolved yourself** by clicking the "Resolve conversation" button at the bottom of each thread. Reviewers don't auto-close their own threads, so an addressed-but-unresolved thread reads as "still waiting on the author" and keeps the PR from moving forward. The author doing the resolve-click is the expected convention on this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60133:
URL: https://github.com/apache/airflow/pull/60133#discussion_r3066480954
##########
scripts/ci/docker-compose/devcontainer-mariadb.yml:
##########
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+services:
+ mariadb:
+ image: mariadb:11.8
+ ports:
+ - "3306:3306"
Review Comment:
The MariaDB container is missing required initialization env vars (e.g. `MARIADB_ALLOW_EMPTY_ROOT_PASSWORD` / `MARIADB_ROOT_PASSWORD`), so it will fail to start with the official `mariadb` image. Also, the declared volume is never mounted into the service. Add the appropriate MariaDB env vars and mount the named volume to `/var/lib/mysql` (or remove the unused volume).
```suggestion
image: mariadb:11.8
environment:
MARIADB_ROOT_PASSWORD: mariadb
ports:
- "3306:3306"
volumes:
- mysql-db-volume:/var/lib/mysql
```
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -785,8 +785,12 @@ def mysql_versions(self) -> list[str]:
if self.all_versions:
return CURRENT_MYSQL_VERSIONS
if self.latest_versions_only:
- return [CURRENT_MYSQL_VERSIONS[-1]]
- return [DEFAULT_MYSQL_VERSION]
+ # Return latest MySQL and latest MariaDB
+ mysql_versions = [v for v in CURRENT_MYSQL_VERSIONS if not v.startswith("mariadb:")]
+ mariadb_versions = [v for v in CURRENT_MYSQL_VERSIONS if v.startswith("mariadb:")]
+ return [mysql_versions[-1], mariadb_versions[-1]]
+ # Test both MySQL and MariaDB LTS by default
+ return [DEFAULT_MYSQL_VERSION, "mariadb:11.8"]
Review Comment:
Indexing `mysql_versions[-1]` / `mariadb_versions[-1]` will raise `IndexError` if either list is empty. That can happen if `CURRENT_MYSQL_VERSIONS` is changed (e.g. temporarily only MySQL or only MariaDB). Guard against empty lists and fall back to defaults. Also, the hard-coded `'mariadb:11.8'` duplicates the version defined in constants—prefer deriving the default MariaDB selection from the MariaDB constants to avoid drift.
##########
scripts/ci/docker-compose/devcontainer-mariadb.yml:
##########
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+services:
+ mariadb:
+ image: mariadb:11.8
Review Comment:
This hard-codes the MariaDB image tag, but `devcontainer.env` introduces `MARIADB_VERSION`. Consider using `image: mariadb:${MARIADB_VERSION}` to keep version selection consistent with the rest of the dev/CI compose setup.
```suggestion
image: mariadb:${MARIADB_VERSION}
```
##########
airflow-core/src/airflow/utils/sqlalchemy.py:
##########
@@ -353,13 +353,8 @@ def with_row_locks(
if not dialect_name:
return query
- # Don't use row level locks if the MySQL dialect (Mariadb & MySQL < 8) does not support it.
if not USE_ROW_LEVEL_LOCKING:
return query
- if dialect_name == "mysql" and not getattr(
- session.bind.dialect if session.bind else None, "supports_for_update_of", False
- ):
- return query
if nowait:
kwargs["nowait"] = True
if skip_locked:
Review Comment:
After removing the MySQL/MariaDB guard, `nowait`/`skip_locked` can be requested on dialects/versions that don’t support them (e.g. older MySQL/MariaDB), which can result in SQL syntax errors at runtime. Consider checking the dialect capability flags (e.g. `supports_for_update_nowait` / `supports_for_update_skip_locked`) before setting those kwargs, and silently degrade when unsupported.
```suggestion
dialect = session.get_bind().dialect
if nowait and getattr(dialect, "supports_for_update_nowait", False):
kwargs["nowait"] = True
if skip_locked and getattr(dialect, "supports_for_update_skip_locked", False):
```
##########
dev/breeze/src/airflow_breeze/params/shell_params.py:
##########
@@ -324,7 +324,8 @@ def backend_version(self) -> str:
if self.backend == "postgres":
version = self.postgres_version
if self.backend == "mysql":
- version = self.mysql_version
+ # Strip mariadb: prefix if present for display
+ version = self.mysql_version.replace("mariadb:", "")
Review Comment:
Using `replace()` will remove `mariadb:` anywhere in the string (not just the prefix) and also drops the engine identity from the returned `backend_version` value. If `backend_version` is used for identifiers (job names, cache keys, artifacts, etc.), MariaDB runs may become indistinguishable from a plain numeric version. Prefer `removeprefix('mariadb:')` for correctness, and consider keeping `backend_version` as the full value while adding a separate display-only property for the stripped version.
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -3026,12 +3026,16 @@ def _update_asset_orphanage(self, session: Session = NEW_SESSION) -> None:
@staticmethod
def _orphan_unreferenced_assets(assets_query: CTE, *, session: Session) -> None:
+ # Disable RETURNING since we only need rowcount, not returned values
+ # This also avoids MariaDB syntax error with DELETE...RETURNING + CTE in EXISTS
deleted_orphaned_assets = session.execute(
- delete(AssetActive).where(
+ delete(AssetActive)
+ .where(
exists().where(
and_(AssetActive.name == assets_query.c.name, AssetActive.uri == assets_query.c.uri)
)
)
+ .execution_options(return_defaults=False)
Review Comment:
`return_defaults=False` does not reliably prevent SQLAlchemy ORM bulk DELETE from using `RETURNING` (it mainly affects default-fetching behavior for INSERT/UPDATE). If the goal is to avoid MariaDB `DELETE ... RETURNING` + CTE issues, use the ORM bulk DML options that control session synchronization/returning behavior (e.g. disable ORM synchronize/fetch strategies via execution options) so SQLAlchemy won’t emit `RETURNING`.
##########
airflow-core/src/airflow/migrations/versions/0036_3_0_0_add_name_field_to_dataset_model.py:
##########
@@ -107,17 +107,29 @@ def downgrade():
# Keep only the datasets with min id if multiple orphaned datasets with the same uri exist.
# This usually happens when all the dags are turned off.
- op.execute(
- """
- with unique_dataset as (select min(id) as min_id, uri as uri from dataset group by id),
- duplicate_dataset_id as (
- select id from dataset join unique_dataset
- on dataset.uri = unique_dataset.uri
- where dataset.id > unique_dataset.min_id
+ if op.get_bind().dialect.name == "mysql":
+ # MySQL/MariaDB error 1093: can't specify target table in a FROM clause of a subquery
+ # that modifies it. Wrapping in a derived table works around this.
+ op.execute(
+ "DELETE FROM dataset WHERE id IN ("
+ " SELECT id FROM ("
+ " SELECT d1.id FROM dataset d1"
+ " JOIN dataset d2 ON d1.uri = d2.uri AND d1.id > d2.id"
+ " ) AS d3"
+ ")"
+ )
+ else:
+ op.execute(
+ """
+ with unique_dataset as (select min(id) as min_id, uri as uri from dataset group by id),
+ duplicate_dataset_id as (
+ select id from dataset join unique_dataset
+ on dataset.uri = unique_dataset.uri
+ where dataset.id > unique_dataset.min_id
+ )
+ delete from dataset where id in (select * from duplicate_dataset_id)
+ """
Review Comment:
The CTE groups by `id`, which prevents calculating a single minimum id per `uri` and makes the join produce many redundant rows. Grouping by `uri` would be both clearer and significantly more efficient for large `dataset` tables while preserving the intended behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4387607343
@rusher This draft PR has been inactive for 13 days since the last triage comment and no response from the author. Closing to keep the queue clean.
You are welcome to reopen this PR when you resume work, or to open a new one addressing the issues previously raised. There is no rush — take your time.
---
_Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #60133: Add MariaDB support to Breeze development environment
URL: https://github.com/apache/airflow/pull/60133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "rusher (via GitHub)" <gi...@apache.org>.
rusher commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3711422983
While MariaDB and MySQL have differences, they remain similar enough for practical testing purposes.
PR #60047 represents the minimal change needed to enable the MariaDB test suite, though it still requires a correction to maintain PostgreSQL and SQLite compatibility.
The goal of this PR:
Enable immediate MariaDB testing capabilities to catch any breaking changes early.
Long-term vision:
A dedicated MariaDB dialect would be the ideal solution to leverage MariaDB-specific optimizations, but that will take considerable time to implement properly. In the meantime, this simple fix allows us to test MariaDB support without delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "rusher (via GitHub)" <gi...@apache.org>.
rusher commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3744994508
Now i understands why mariadb did have issues with airflow :
This isn't due to airflow, but in sqlalchemy. 2 things :
* a small issue : sqlalchemy mariadb sequence incorrectly created when using explicit cycle=False option [PR](https://github.com/sqlalchemy/sqlalchemy/pull/13074)
* and the big issue : when using "mysql" prefix, the runtime check detecting mariadb doesn't create a proper mariadb dialect like when using "mariadb" prefix normally. when fixing that with a [patch](https://github.com/user-attachments/files/24593641/Add_MariaDB-specific_compiler_and_UUID_support_to_runtime_detection__When_MariaDB_is_detec.patch)
After correcting that, there is only 2 queries to be corrected in migration commands.
So submitting correction to sqlachemy for now, and i'll ping back when corrections will be released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "rusher (via GitHub)" <gi...@apache.org>.
rusher commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4178460589
rebased on main branch.
this is now simplified, since main now use SQLAlchemy recent version that correct different issues.
So to recapitulate :
I've separated the changes into 2 differents commit :
[[0fe7093](https://github.com/apache/airflow/pull/60133/commits/0fe70939974e9c07b6cdbae34cd8e5c7e840ad9e) ](https://github.com/apache/airflow/pull/60133/commits/b9da4fe819503ff1aad67aa0943da3ac33707d8d) contains the change to make mariadb work
this fix contains :
* with_row_locks: the with_row_locks function that made sense long time ago is now problematic : MariaDB 10.6+ supports FOR UPDATE, NOWAIT, SKIP LOCKED, and SQLAlchemy support it natively well. The supports_for_update_of check is incorrect for mariadb, since it support all locking features but 'FOR UPDATE OF <table>'
* Migration 0036: Fixed error 1093 by wrapping subquery in derived table for MariaDB
* Migration 0049: Added MariaDB-specific REGEXP_REPLACE syntax (3-arg PCRE2 vs MySQL 8's 6-arg)
* scheduler_job_runner.py: disable RETURNING clause because unused, and problematic in MariaDB (RETUNING with CTE)
* test_exceptions.py: test improvement, to permit using possible different connectors and MySQL and MariaDB error message/parameter differences
It would make sense to add this commit whatever the goal to have mariadb in breeze testing.
the second commit [[d45c8ea](https://github.com/apache/airflow/pull/60133/commits/d45c8ea135eb3f1ed09b07effecaad2ec7f083bb)](https://github.com/apache/airflow/pull/60133/commits/b47cea389a9ed4f97a02820c992f505da82a4e4c) is to add mariadb to test suite
Must i create a separate PR with only the first commit ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3712287971
BTW. You might freely continue rebasing your PR and base your testing on top of it - while the discussion is happening. There is no need to merge it to do it, what is more important though is that we decide - as a community whether we are going to support it - even for testing purposes.
Context: We had very bad experience with MsSQL in the past and we eventually had to remove it (we were lucky it was merged as "experimental" - but a lot of our users who used it had problems when we removed it and wanted it to continue - even if it was clearly marked as "experimental".
Now I understand what you are saying that it's "close enough to MySQL", but this is a completely vague statement that does not even attempt to describe "how close" it is. In the past for example there was a LONG period of time SKIP LOCKED was not supported by MariaDB. And we are currently using **some** features from MySQL like json fields etc. that might prove to behave differently, even the PR https://github.com/apache/airflow/pull/60047 shows that there are some significant changes that will make it more difficult to maintain and keep mariadb support in parallel to mysql. This PR is a proof that there are differences - and ones that add maintenance overhead.
So my best guess (but again - you MUST start devlist discussion if you want to support it) you will have to show exactly what kind of changes are necessary to support MariaDB in order to even begin a discussion "should we merge it". Which basically means that you will have to heave the PR green, when running it with your changes and have all the tests passing.
And you - rebasing it continuously - will be able to see also - while other changes is implemented, how much extra maintenance it is to keep your PR is green - this is a great opportunity to either proof that it is fine - if it will be relatively painless to keep it green over the course of weeks or months, or whether it is actually difficult and will require maintainers to spend extra time to test and fix issues.
So there are only good things with keeping your PR open and continuously rebased - while the discussion is running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "andreahlert (via GitHub)" <gi...@apache.org>.
andreahlert commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3886284677
Agree with @potiuk, devlist first. Took a quick look and there are a few things to address in the code too (missing defaults, edge cases, broader regex change). Happy to detail if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "rusher (via GitHub)" <gi...@apache.org>.
rusher commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3739296403
updated correction. please mark it as draft for now too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4035172851
You need to rebase and resolve conflicts please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "vuvova (via GitHub)" <gi...@apache.org>.
vuvova commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3891272743
Could someone please enable CI workflows? Just to understand the scope of changes that the new backend will need and to present them on devlist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3712256368
> The goal of this PR is to enable immediate MariaDB testing capabilities to catch any breaking changes early.
>
> Long-term vision: A dedicated MariaDB dialect would be the ideal solution to leverage MariaDB-specific optimizations, but that will take time to implement properly. In the meantime, this simple fix allows us to test MariaDB support without delay.
>
> please tell if your ok with that
Again - not my decision, by community decision that should be discussed on devlist. What **I** think will matter only in the context of what others - who will be maintaining it - think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-3711260445
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MariaDB support to Breeze development environment [airflow]
Posted by "rusher (via GitHub)" <gi...@apache.org>.
rusher commented on PR #60133:
URL: https://github.com/apache/airflow/pull/60133#issuecomment-4178819329
for info, tests are ok : https://github.com/rusher/airflow/actions/runs/23904472220/job/69715653768 (somes errors, but just because that's a fork, not due to changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org