You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/30 04:16:13 UTC
[GitHub] [spark] c21 commented on a change in pull request #33148: [SPARK-33298][CORE][FOLLOWUP] Add Unstable annotation to newly added methods of `FileCommitProtocol`
c21 commented on a change in pull request #33148:
URL: https://github.com/apache/spark/pull/33148#discussion_r661117657
##########
File path: core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
##########
@@ -107,10 +111,9 @@ abstract class FileCommitProtocol extends Logging {
* if a task is going to write out multiple files to the same dir. The file commit protocol only
* guarantees that files written by different tasks will not conflict.
*
- * This API should be implemented and called, instead of
- * [[newTaskTempFile(taskContest, dir, ext)]]. Provide a default implementation here to be
- * backward compatible with custom [[FileCommitProtocol]] implementations before Spark 3.2.0.
+ * @since 3.2.0
*/
+ @Unstable
Review comment:
@HyukjinKwon - ah I see, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org