You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/01 15:55:49 UTC
[GitHub] [flink] libenchao opened a new pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
libenchao opened a new pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737
…tation for blink planner
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix blink planner code generation exceeds 64k java method limitation.
## Brief change log
- Add isSplit field in CodeGeneratorContext
- Split expressions when exceeds threshold in ExprCodeGenerator
- Use reuseableLocalVariable in GeneratedExpression.deepCopy
## Verifying this change
This change added tests and can be verified as follows:
- CalcITCase. testLongProjectionList
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570229054
@JingsongLi Thanks for the review.
1. I'll try to align the behavior with old planner, and give you feedback after that.
2. Yes. I also realized that, and fixed all places I found for now. However, this can only happen when the Expression is longer than TableConfig.maxGeneratedCodeLength.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143193051 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
* c5bceadd1288ab341212b44480c90d10329f5c74 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143193051) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143193051 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
* c5bceadd1288ab341212b44480c90d10329f5c74 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143193051) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#discussion_r363151698
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
##########
@@ -285,11 +287,30 @@ class ExprCodeGenerator(ctx: CodeGeneratorContext, nullableInput: Boolean)
case _ => // ok
}
- val setFieldsCode = fieldExprs.zipWithIndex.map { case (fieldExpr, index) =>
+ val setFieldsCodes = fieldExprs.zipWithIndex.map { case (fieldExpr, index) =>
val pos = fieldExprIdxToOutputRowPosMap.getOrElse(index,
throw new CodeGenException(s"Illegal field expr index: $index"))
baseRowSetField(ctx, returnTypeClazz, outRow, pos.toString, fieldExpr, outRowWriter)
- }.mkString("\n")
+ }
+ val totalLen = setFieldsCodes.map(_.length).sum
+ val maxCodeLength = ctx.tableConfig.getMaxGeneratedCodeLength
+ val setFieldsCode = if (allowSplit && totalLen > maxCodeLength) {
+ // do the split.
+ ctx.setSplit()
+ setFieldsCodes.map(project => {
+ val methodName = newName("split")
+ val method =
+ s"""
+ |private void $methodName() throw Exception {
Review comment:
Thanks for the review, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-571023375
This temporary fixing looks good to me. Now we limit this fixing to the Calc only. It's not a perfect solution. But it does solve the problem.
@wuchong @KurtYoung What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143193051 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:780431a2687cd36cc23e9c4815e041c279b8fb97 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:780431a2687cd36cc23e9c4815e041c279b8fb97
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
* c5bceadd1288ab341212b44480c90d10329f5c74 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143193051) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108)
* 780431a2687cd36cc23e9c4815e041c279b8fb97 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570981911
@libenchao Thanks for you updating.
> I changed TableConfig.maxGeneratedCodeLength to 1, and run all the tests in blink planner
Good job!
> narrow down the scope of this simple fix, which just targets long projection list
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#discussion_r363149324
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
##########
@@ -285,11 +287,30 @@ class ExprCodeGenerator(ctx: CodeGeneratorContext, nullableInput: Boolean)
case _ => // ok
}
- val setFieldsCode = fieldExprs.zipWithIndex.map { case (fieldExpr, index) =>
+ val setFieldsCodes = fieldExprs.zipWithIndex.map { case (fieldExpr, index) =>
val pos = fieldExprIdxToOutputRowPosMap.getOrElse(index,
throw new CodeGenException(s"Illegal field expr index: $index"))
baseRowSetField(ctx, returnTypeClazz, outRow, pos.toString, fieldExpr, outRowWriter)
- }.mkString("\n")
+ }
+ val totalLen = setFieldsCodes.map(_.length).sum
+ val maxCodeLength = ctx.tableConfig.getMaxGeneratedCodeLength
+ val setFieldsCode = if (allowSplit && totalLen > maxCodeLength) {
+ // do the split.
+ ctx.setSplit()
+ setFieldsCodes.map(project => {
+ val methodName = newName("split")
+ val method =
+ s"""
+ |private void $methodName() throw Exception {
Review comment:
`throws`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143193051 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:780431a2687cd36cc23e9c4815e041c279b8fb97 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4117 TriggerType:PUSH TriggerID:780431a2687cd36cc23e9c4815e041c279b8fb97
Hash:780431a2687cd36cc23e9c4815e041c279b8fb97 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143206920 TriggerType:PUSH TriggerID:780431a2687cd36cc23e9c4815e041c279b8fb97
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
* c5bceadd1288ab341212b44480c90d10329f5c74 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143193051) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108)
* 780431a2687cd36cc23e9c4815e041c279b8fb97 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143206920) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4117)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
* c5bceadd1288ab341212b44480c90d10329f5c74 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570881019
@JingsongLi @wuchong I go over the implementation again, and find that it indeed has many corner cases.
- I changed `TableConfig.maxGeneratedCodeLength` to 1, and run all the tests in blink planner, **762/6117** tests failed.
- For comparison, I did the same thing to old planner, and found **21/2321** tests failed.
So, it's indeed not easy to do code split currently. And I propose to narrow down the scope of this simple fix, which just targets long projection list. Then we can just focus on `CalcCodeGenerator` and add a param `allowSplit` to `ExprCodeGenerator.generateResultExpression`.
What's your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-571038554
@wuchong Thanks for the review. I've updated the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570144063
cc @JingsongLi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570063666
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fdd885648d4585ef6a77fc71584aef144c99af64 (Wed Jan 01 15:59:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10737: [WIP][FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10737: [WIP][FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570108667
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143132521 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:fe8321877a13fcaf202f24643e3ff0933cfb63c9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098 TriggerType:PUSH TriggerID:fe8321877a13fcaf202f24643e3ff0933cfb63c9
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143193051 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:c5bceadd1288ab341212b44480c90d10329f5c74 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108 TriggerType:PUSH TriggerID:c5bceadd1288ab341212b44480c90d10329f5c74
Hash:780431a2687cd36cc23e9c4815e041c279b8fb97 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4117 TriggerType:PUSH TriggerID:780431a2687cd36cc23e9c4815e041c279b8fb97
Hash:780431a2687cd36cc23e9c4815e041c279b8fb97 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143206920 TriggerType:PUSH TriggerID:780431a2687cd36cc23e9c4815e041c279b8fb97
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
* fe8321877a13fcaf202f24643e3ff0933cfb63c9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143132521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4098)
* c5bceadd1288ab341212b44480c90d10329f5c74 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143193051) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4108)
* 780431a2687cd36cc23e9c4815e041c279b8fb97 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143206920) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4117)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:PUSH TriggerID:263bb0c191d7090cc1971a4973fc9153bfffc024
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142831085 TriggerType:MANUAL TriggerID:570108667
Hash:263bb0c191d7090cc1971a4973fc9153bfffc024 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029 TriggerType:MANUAL TriggerID:570108667
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
* 263bb0c191d7090cc1971a4973fc9153bfffc024 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142831085) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4029)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142804673 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022 TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142804673) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10737: [FLINK-15430][table-planner-blink] Fix Java 64K method compiling limi…
URL: https://github.com/apache/flink/pull/10737#issuecomment-570066864
<!--
Meta data
Hash:fdd885648d4585ef6a77fc71584aef144c99af64 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fdd885648d4585ef6a77fc71584aef144c99af64
-->
## CI report:
* fdd885648d4585ef6a77fc71584aef144c99af64 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services