[GitHub] [kafka] ijuma commented on a change in pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #9182:
URL: https://github.com/apache/kafka/pull/9182#discussion_r484981150



##########
File path: core/src/main/scala/kafka/utils/Log4jController.scala
##########
@@ -87,9 +87,10 @@ object Log4jController {
 class Log4jController extends Log4jControllerMBean {
 
   def getLoggers: util.List[String] = {
-    Log4jController.loggers.map {
+    // we replace scala collection by java collection so mbean client is able to parse it without scala library.

Review comment:
       Instead of `parse`, we should say `deserialize`.

##########
File path: core/src/test/scala/kafka/utils/LoggingTest.scala
##########
@@ -26,6 +26,12 @@ import org.junit.Assert.{assertEquals, assertTrue}
 
 class LoggingTest extends Logging {
 
+  @Test
+  def testTypeOfGetLoggers(): Unit = {

Review comment:
       Can we add a comment to the test too since this is not obvious.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org