You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/08 15:18:55 UTC
[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #506: add the comment of ConsistentHash
Patrick0308 commented on a change in pull request #506:
URL: https://github.com/apache/dubbo-go/pull/506#discussion_r422203772
##########
File path: cluster/loadbalance/consistent_hash.go
##########
@@ -53,16 +53,16 @@ func init() {
extension.SetLoadbalance(ConsistentHash, NewConsistentHashLoadBalance)
}
-// ConsistentHashLoadBalance ...
+// ConsistentHashLoadBalance Implementation of load balancing: using consistent hashing
Review comment:
See https://golang.org/doc/effective_go.html#commentary, after function name, the first character of word don't need to be capitalized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org