[GitHub] [hive] TuroczyX commented on pull request #4197: HIVE-27217: Rethrow unhandled exception in addWriteNotificationLogInB…

["TuroczyX (via GitHub)" <gi...@apache.org>]

TuroczyX commented on PR #4197:
URL: https://github.com/apache/hive/pull/4197#issuecomment-1496591734

   This is truly a best practice in any OOP language to rethrow the exception.  To swallow it is rarely a good idea, but **could be** a good choice especially when the domain logic should manage those error scenario where exception is an expected behaviors' from the business logic perspective. 
   
   Here as I see this notification log is mainly for 
   `TApplicationException.UNKNOWN_METHOD ||  TApplicationException.WRONG_METHOD_NAME) `
   
   Which is the main use-case when a method is not implemented and it can't be goes into notification log. Do we have here different use cases as well? If yes then your point is right to rethrow it.
   
   Also if you rethrow where it will be catched? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org