You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/03/15 16:39:53 UTC
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1215
STORM-1629 (For 1.x) Files/move doesn't work properly with non-empty directory in Windows
PR based on master is here: https://github.com/apache/storm/pull/1214
* Use FileUtils/moveDirectory on Windows
* It copies whole contents inside directory, and delete directory
* Keep using Files/move on non-Windows
* it's still better option since doesn't require copying contents inside directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1629-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1215
----
commit 7b559ef3d8e02047a15860d261bc0a40d08834e0
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-03-15T15:37:28Z
STORM-1629 Files/move doesn't work properly with non-empty directory in Windows
* Use FileUtils/moveDirectory on Windows
* It copies whole contents inside directory, and delete directory
* Keep using Files/move on non-Windows
* it's still better option since doesn't require copying contents inside directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1215#issuecomment-198044924
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1215#issuecomment-197690330
Please review #1214 as well. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/1215#issuecomment-197637925
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1215#issuecomment-197152524
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1629 (For 1.x) Files/move doesn't work p...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1215#issuecomment-197637529
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---