[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6749: mm/kasan: node header should updated from unpoisoning memory

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #6749:
URL: https://github.com/apache/incubator-nuttx/pull/6749#discussion_r934625210


##########
mm/mm_heap/mm_memalign.c:
##########
@@ -227,5 +226,7 @@ FAR void *mm_memalign(FAR struct mm_heap_s *heap, size_t alignment,
   kasan_unpoison((FAR void *)alignedchunk,
                  mm_malloc_size((FAR void *)alignedchunk));
 
+  MM_ADD_BACKTRACE(heap, node);

Review Comment:
   ditto



##########
mm/mm_heap/mm_malloc.c:
##########
@@ -239,6 +238,7 @@ FAR void *mm_malloc(FAR struct mm_heap_s *heap, size_t size)
   if (ret)
     {
       kasan_unpoison(ret, mm_malloc_size(ret));
+      MM_ADD_BACKTRACE(heap, node);

Review Comment:
   move before kasan_unpoison



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org