You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by harshach <gi...@git.apache.org> on 2015/10/27 16:46:39 UTC
[GitHub] storm pull request: STORM-1134. Windows: Fix log4j config.
GitHub user harshach opened a pull request:
https://github.com/apache/storm/pull/823
STORM-1134. Windows: Fix log4j config.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-1134
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit cc53fe7cad65d420ce2992af4a2686e09532dcb7
Author: Sriharsha Chintalapani <ma...@harsha.io>
Date: 2015-10-27T15:45:42Z
STORM-1134. Windows: Fix log4j config.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1134. Windows: Fix log4j config.
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/823#issuecomment-151575912
Looks OK to me I am +1, but I don't have access to a windows box to test it on, so I am assuming that you have done that @harshach
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1134. Windows: Fix log4j config.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/823
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1134. Windows: Fix log4j config.
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/823#issuecomment-151727427
@revans2 thanks for the review. Yes tested it on windows 7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---