You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/16 19:45:58 UTC

[GitHub] [spark-docker] martin-g commented on a diff in pull request #11: [SPARK-40805] Use `spark` username in official image

martin-g commented on code in PR #11:
URL: https://github.com/apache/spark-docker/pull/11#discussion_r996485107


##########
3.3.0/scala2.12-java11-python3-r-ubuntu/entrypoint.sh:
##########
@@ -103,5 +103,13 @@ case "$1" in
     ;;
 esac
 
+switch_spark_if_root() {
+  if [ $(id -u) -ne 0 ]; then

Review Comment:
   IMO it would be simpler as:
   ```bash
   if [ $(id -u) -eq 0 ]; then
     echo gosu spark
   fi
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org