You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Dominique Pfister (JIRA)" <ji...@apache.org> on 2008/04/14 11:17:05 UTC

[jira] Created: (JCR-1535) Some tests assume that an implementation of javax.jcr.Item overrides equals()

Some tests assume that an implementation of javax.jcr.Item overrides equals()
-----------------------------------------------------------------------------

                 Key: JCR-1535
                 URL: https://issues.apache.org/jira/browse/JCR-1535
             Project: Jackrabbit
          Issue Type: Bug
          Components: jackrabbit-jcr-tests
    Affects Versions: 1.5
            Reporter: Dominique Pfister


The following 3 tests (followed by the line number containing the bad assertion):

org.apache.jackrabbit.test.api.ReferencesTest.testReferenceTarget:135
org.apache.jackrabbit.test.api.ReferencesTest.testAlterReference:169
org.apache.jackrabbit.test.api.version.VersionHistoryTest:152

assume that an implementation of javax.jcr.Item overrides equals(), such that 

Assert.assertEquals(n1, n2) or 
java.util.Set.contains(n1) 

works for two "equal" nodes n1,n2 or for some node n1 that has been previously put into a set. However, there is no section in the specification that would mandate this. The tests above should therefore replace assertEquals() with one of the other mechanism that officially supported, such as javax.jcr.Node.isSame().



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1535) Some tests assume that an implementation of javax.jcr.Item overrides equals()

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1535:
-------------------------------

    Affects Version/s:     (was: 1.5)
                       1.4
        Fix Version/s: 1.5

> Some tests assume that an implementation of javax.jcr.Item overrides equals()
> -----------------------------------------------------------------------------
>
>                 Key: JCR-1535
>                 URL: https://issues.apache.org/jira/browse/JCR-1535
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests
>    Affects Versions: 1.4
>            Reporter: Dominique Pfister
>             Fix For: 1.5
>
>
> The following 3 tests (followed by the line number containing the bad assertion):
> org.apache.jackrabbit.test.api.ReferencesTest.testReferenceTarget:135
> org.apache.jackrabbit.test.api.ReferencesTest.testAlterReference:169
> org.apache.jackrabbit.test.api.version.VersionHistoryTest:152
> assume that an implementation of javax.jcr.Item overrides equals(), such that 
> Assert.assertEquals(n1, n2) or 
> java.util.Set.contains(n1) 
> works for two "equal" nodes n1,n2 or for some node n1 that has been previously put into a set. However, there is no section in the specification that would mandate this. The tests above should therefore replace assertEquals() with one of the other mechanism that officially supported, such as javax.jcr.Node.isSame().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1535) Some tests assume that an implementation of javax.jcr.Item overrides equals()

Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dominique Pfister resolved JCR-1535.
------------------------------------

    Resolution: Fixed

Fixed in revision 647765.

> Some tests assume that an implementation of javax.jcr.Item overrides equals()
> -----------------------------------------------------------------------------
>
>                 Key: JCR-1535
>                 URL: https://issues.apache.org/jira/browse/JCR-1535
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests
>    Affects Versions: 1.5
>            Reporter: Dominique Pfister
>
> The following 3 tests (followed by the line number containing the bad assertion):
> org.apache.jackrabbit.test.api.ReferencesTest.testReferenceTarget:135
> org.apache.jackrabbit.test.api.ReferencesTest.testAlterReference:169
> org.apache.jackrabbit.test.api.version.VersionHistoryTest:152
> assume that an implementation of javax.jcr.Item overrides equals(), such that 
> Assert.assertEquals(n1, n2) or 
> java.util.Set.contains(n1) 
> works for two "equal" nodes n1,n2 or for some node n1 that has been previously put into a set. However, there is no section in the specification that would mandate this. The tests above should therefore replace assertEquals() with one of the other mechanism that officially supported, such as javax.jcr.Node.isSame().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.