[GitHub] [flink] WeiZhong94 commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

[GitBox <gi...@apache.org>]

WeiZhong94 commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r285056658
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/python/PythonDriver.java
 ##########
 @@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.client.python;
+
+import org.apache.flink.core.fs.Path;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import py4j.GatewayServer;
+
+import java.net.InetAddress;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * A main class used to launch Python applications. It executes python as a
+ * subprocess and then has it connect back to the JVM to access system properties, etc.
+ */
+public class PythonDriver {
+	private static final Logger LOG = LoggerFactory.getLogger(PythonDriver.class);
+
+	public static void main(String[] args) {
+		// the python job needs at least 2 args.
+		// e.g. python a.py
+		// e.g. py-module a.b
+		if (args.length < 2) {
+			LOG.error("Args is invalid");
+			System.exit(1);
+		}
+		Map<String, List<String>> parseArgs = new HashMap<>();
+		// parse args
+		parseOption(parseArgs, args);
+		// start gateway server
+		GatewayServer gatewayServer = startGatewayServer();
+		// prepare python env
+
+		// map filename to its Path
+		Map<String, Path> filePathMap = new HashMap<>();
+		// command which will be exec in python progress.
+		List<String> commands = new ArrayList<>();
+		// construct the filePathMap and the commands
+		constructCommand(filePathMap, commands, parseArgs);
+		try {
+			// prepare the exec environment of python progress.
+			PythonUtil.PythonEnvironment pythonEnv = PythonUtil.preparePythonEnvironment(filePathMap);
+			// set env variable PYFLINK_GATEWAY_PORT for connecting of python gateway in python progress.
+			pythonEnv.systemEnv.put("PYFLINK_GATEWAY_PORT", String.valueOf(gatewayServer.getListeningPort()));
+			// start the python process.
+			Process pythonProcess = PythonUtil.startPythonProcess(pythonEnv, commands);
+			int exitCode = pythonProcess.waitFor();
+			if (exitCode != 0) {
+				throw new RuntimeException("Python process exits with code: " + exitCode);
+			}
+		} catch (Exception e) {
+			LOG.error("run python process failed {}", e.getMessage());
 
 Review comment:
   How about log the whole exception object, which contains both message and stack trace?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services