You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by na...@apache.org on 2009/12/18 20:18:56 UTC
svn commit: r892352 - in /hadoop/hive/trunk: CHANGES.txt
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Author: namit
Date: Fri Dec 18 19:18:56 2009
New Revision: 892352
URL: http://svn.apache.org/viewvc?rev=892352&view=rev
Log:
HIVE-595 throw error if rename fails
(Zheng Shao via namit)
Modified:
hadoop/hive/trunk/CHANGES.txt
hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Modified: hadoop/hive/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/CHANGES.txt?rev=892352&r1=892351&r2=892352&view=diff
==============================================================================
--- hadoop/hive/trunk/CHANGES.txt (original)
+++ hadoop/hive/trunk/CHANGES.txt Fri Dec 18 19:18:56 2009
@@ -330,6 +330,9 @@
HIVE-993 commons-dhcp not working
(Bennie Schut via namit)
+ HIVE-595 throw error if rename fails
+ (Zheng Shao via namit)
+
Release 0.4.0 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java?rev=892352&r1=892351&r2=892352&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Fri Dec 18 19:18:56 2009
@@ -742,7 +742,11 @@
for(int i=0; i<srcs.length; i++) {
FileStatus [] items = fs.listStatus(srcs[i].getPath());
for(int j=0; j<items.length; j++) {
- fs.rename(items[j].getPath(), new Path(destf, items[j].getPath().getName()));
+ Path source = items[j].getPath();
+ Path target = new Path(destf, items[j].getPath().getName());
+ if (!fs.rename(source, target)) {
+ throw new IOException("Cannot move " + source + " to " + target);
+ }
}
}
} catch (IOException e) {