You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/27 12:03:36 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #23125: Rename resource to storage unit
Pace2Car opened a new pull request, #23125:
URL: https://github.com/apache/shardingsphere/pull/23125
For #21671.
Changes proposed in this pull request:
- Rename resource related Exception to shorage unit
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #23125: Rename resource to storage unit
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #23125:
URL: https://github.com/apache/shardingsphere/pull/23125#discussion_r1058073851
##########
features/db-discovery/distsql/handler/src/main/java/org/apache/shardingsphere/dbdiscovery/distsql/handler/update/AlterDatabaseDiscoveryRuleStatementUpdater.java:
##########
@@ -75,7 +75,7 @@ private Collection<String> getToBeAlteredRuleNames(final AlterDatabaseDiscoveryR
private void checkToBeAlteredResources(final String databaseName, final AlterDatabaseDiscoveryRuleStatement sqlStatement, final ShardingSphereResourceMetaData resourceMetaData) {
Collection<String> notExistedResources = resourceMetaData.getNotExistedResources(getToBeAlteredResourceNames(sqlStatement));
Review Comment:
Should rename `notExistedResources` to `notExistedStorageUnits`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23125: Rename resource to storage unit
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23125:
URL: https://github.com/apache/shardingsphere/pull/23125#issuecomment-1365873831
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23125?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23125](https://codecov.io/gh/apache/shardingsphere/pull/23125?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94e5951) into [master](https://codecov.io/gh/apache/shardingsphere/commit/28e8fbaa5402d3034f12089ef13e7e9fa295ae8d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e8fba) will **not change** coverage.
> The diff coverage is `48.57%`.
```diff
@@ Coverage Diff @@
## master #23125 +/- ##
=========================================
Coverage 49.82% 49.82%
Complexity 2439 2439
=========================================
Files 4111 4111
Lines 57540 57540
Branches 9088 9088
=========================================
Hits 28668 28668
Misses 26352 26352
Partials 2520 2520
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ion/storageunit/DuplicateStorageUnitException.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL3N0b3JhZ2V1bml0L0R1cGxpY2F0ZVN0b3JhZ2VVbml0RXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ception/storageunit/EmptyStorageUnitException.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL3N0b3JhZ2V1bml0L0VtcHR5U3RvcmFnZVVuaXRFeGNlcHRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tion/storageunit/InvalidStorageUnitsException.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL3N0b3JhZ2V1bml0L0ludmFsaWRTdG9yYWdlVW5pdHNFeGNlcHRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...rageunit/MissingRequiredStorageUnitsException.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL3N0b3JhZ2V1bml0L01pc3NpbmdSZXF1aXJlZFN0b3JhZ2VVbml0c0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...eunit/StorageUnitDefinitionViolationException.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL3N0b3JhZ2V1bml0L1N0b3JhZ2VVbml0RGVmaW5pdGlvblZpb2xhdGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...eption/storageunit/StorageUnitInUsedException.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvZXhjZXB0aW9uL3N0b3JhZ2V1bml0L1N0b3JhZ2VVbml0SW5Vc2VkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../validate/DataSourcePropertiesValidateHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL2hhbmRsZXIvdmFsaWRhdGUvRGF0YVNvdXJjZVByb3BlcnRpZXNWYWxpZGF0ZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...dler/update/CreateEncryptRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVFbmNyeXB0UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `56.66% <0.00%> (ø)` | |
| [...type/table/AlterTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS90YWJsZS9BbHRlclRhYmxlU3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ype/table/RenameTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS90YWJsZS9SZW5hbWVUYWJsZVN0YXRlbWVudFNjaGVtYVJlZnJlc2hlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/23125/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23125: Rename resource to storage unit
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #23125:
URL: https://github.com/apache/shardingsphere/pull/23125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org