[jira] [Commented] (FLINK-9408) Retry JM-RM connection in case of explicit disconnect

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483984#comment-16483984 ] 

ASF GitHub Bot commented on FLINK-9408:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/6056

    [FLINK-9408] Let JM try to reconnect to RM

    ## What is the purpose of the change
    
    This commit changes the behaviour of the JM to always try to reconnect to the latest known RM address.
    
    cc @GJL
    
    ## Brief change log
    
    - Always reconnect in case of a connection loss to the RM
    
    ## Verifying this change
    
    - Added `JobMasterTest#testResourceManagerConnectionAfterRegainingLeadership` and `JobMasterTest#testReconnectionAfterDisconnect`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixJMReconnection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6056
    
----
commit bc64cca4b4f2a40c242a314223c064b884cece28
Author: Till Rohrmann <tr...@...>
Date:   2018-05-22T13:53:38Z

    [FLINK-9408] Let JM try to reconnect to RM
    
    This commit changes the behaviour of the JM to always try to reconnect to the latest known RM address.

----


> Retry JM-RM connection in case of explicit disconnect
> -----------------------------------------------------
>
>                 Key: FLINK-9408
>                 URL: https://issues.apache.org/jira/browse/FLINK-9408
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The JM should try to reconnect to the RM not only in the case of a heartbeat timeout but also in case of an explicit disconnect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)