You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/04/13 11:57:58 UTC

[GitHub] [wicket] martin-g commented on pull request #510: [WICKET-6971] NullPointerException in ModificationWatcher

martin-g commented on PR #510:
URL: https://github.com/apache/wicket/pull/510#issuecomment-1097965674

   Thanks for the PR, @try0 !
   
   I wonder whether we should try/catch the whole method body. 
   Closing a resource is a best effort operation and it should not break the following operations.
   Currently the method `throws IOException`, i.e. the errors should be propagated. But I don't see much value in this. IMO catching `Exception` and logging it as a WARNING would be better.
   
   Let's hear some more opinions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org