You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/04 21:56:43 UTC
[kudu-CR] ssl: switch to older APIs for initializing SSL
Hello Dan Burkert, Sailesh Mukil, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4957
to review the following change.
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
ssl: switch to older APIs for initializing SSL
This enables support for OpenSSL 1.0.0 as found on RHEL 6.4.
Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
---
M src/kudu/util/net/ssl_factory.cc
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/4957/1
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[kudu-CR] ssl: switch to older APIs for initializing SSL
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
Patch Set 1:
(1 comment)
After reading the attached discussion, LGTM.
http://gerrit.cloudera.org:8080/#/c/4957/1/src/kudu/util/net/ssl_factory.cc
File src/kudu/util/net/ssl_factory.cc:
PS1, Line 89: SSL v2
nit: no space
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[kudu-CR] ssl: switch to older APIs for initializing SSL
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4957/1/src/kudu/util/net/ssl_factory.cc
File src/kudu/util/net/ssl_factory.cc:
PS1, Line 84: ctx_ == nullptr
nit: I didn't notice that earlier, but while you are at it -- since ctx_ is a smart pointer, it's more idiomatic to write something like
if (!ctx_) {
...
}
instead of if (ctx_ == nullptr)
PS1, Line 90: on early versions of RHEL6
Does it make sense to specify that it's 6.4 and earlier?
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[kudu-CR] ssl: switch to older APIs for initializing SSL
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] ssl: switch to older APIs for initializing SSL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
ssl: switch to older APIs for initializing SSL
This enables support for OpenSSL 1.0.0 as found on RHEL 6.4.
Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Reviewed-on: http://gerrit.cloudera.org:8080/4957
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/net/ssl_factory.cc
1 file changed, 12 insertions(+), 4 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] ssl: switch to older APIs for initializing SSL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Sailesh Mukil, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4957
to look at the new patch set (#2).
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
ssl: switch to older APIs for initializing SSL
This enables support for OpenSSL 1.0.0 as found on RHEL 6.4.
Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
---
M src/kudu/util/net/ssl_factory.cc
1 file changed, 12 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/4957/2
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[kudu-CR] ssl: switch to older APIs for initializing SSL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: ssl: switch to older APIs for initializing SSL
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4957/1/src/kudu/util/net/ssl_factory.cc
File src/kudu/util/net/ssl_factory.cc:
PS1, Line 84: ctx_ == nullptr
> nit: I didn't notice that earlier, but while you are at it -- since ctx_ is
Done
PS1, Line 89: SSL v2
> nit: no space
Done
PS1, Line 90: on early versions of RHEL6
> Does it make sense to specify that it's 6.4 and earlier?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes