You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2020/11/26 03:34:20 UTC

[spark] branch branch-3.0 updated: [SPARK-33565][INFRA][FOLLOW-UP][3.0] Keep the test coverage with Python 3.8 in GitHub Actions

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new 7503c4a  [SPARK-33565][INFRA][FOLLOW-UP][3.0] Keep the test coverage with Python 3.8 in GitHub Actions
7503c4a is described below

commit 7503c4a3ab1854d62c49d02221c26fb220546ede
Author: HyukjinKwon <gu...@apache.org>
AuthorDate: Thu Nov 26 12:31:02 2020 +0900

    [SPARK-33565][INFRA][FOLLOW-UP][3.0] Keep the test coverage with Python 3.8 in GitHub Actions
    
    ### What changes were proposed in this pull request?
    
    This is a backport PR of https://github.com/apache/spark/pull/30510
    
    This PR proposes to keep the test coverage with Python 3.8 in GitHub Actions. It is not tested for now in Jenkins due to an env issue.
    
    **Before this change in GitHub Actions:**
    
    ```
    ========================================================================
    Running PySpark tests
    ========================================================================
    Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
    Will test against the following Python executables: ['/usr/bin/python3', 'python2.7', 'pypy3']
    ...
    ```
    
    **After this change in GitHub Actions:**
    
    ```
    
    ========================================================================
    Running PySpark tests
    ========================================================================
    Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
    Will test against the following Python executables: ['python3.8', 'python2.7', 'pypy3']
    ```
    
    ### Why are the changes needed?
    
    To keep the test coverage with Python 3.8 in GitHub Actions.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, dev-only.
    
    ### How was this patch tested?
    
    GitHub Actions in this build will test.
    
    Closes #30511 from HyukjinKwon/SPARK-33565-3.0.
    
    Authored-by: HyukjinKwon <gu...@apache.org>
    Signed-off-by: HyukjinKwon <gu...@apache.org>
---
 dev/run-tests.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dev/run-tests.py b/dev/run-tests.py
index fde1def..d58884f 100755
--- a/dev/run-tests.py
+++ b/dev/run-tests.py
@@ -484,6 +484,12 @@ def run_python_tests(test_modules, parallelism, with_coverage=False):
     if test_modules != [modules.root]:
         command.append("--modules=%s" % ','.join(m.name for m in test_modules))
     command.append("--parallelism=%i" % parallelism)
+    if "GITHUB_ACTIONS" in os.environ:
+        # See SPARK-33565. Python 3.8 was temporarily removed as its default Python executables
+        # to test because of Jenkins environment issue. Once Jenkins has Python 3.8 to test,
+        # we should remove this change back and add python3.8 into python/run-tests.py script.
+        command.append("--python-executable=%s" % ','.join(
+            x for x in ["python3.8", "python2.7", "pypy3", "pypy"] if which(x)))
     run_cmd(command)
 
     if with_coverage:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org