[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9126: add integration-test (dql dml) for broadcast feature

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #9126:
URL: https://github.com/apache/shardingsphere/pull/9126#discussion_r562694779



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/it/BatchIT.java
##########
@@ -134,6 +134,10 @@ private void mergeMetadata(final DataSet original, final DataSet dist) {
     
     private void mergeRow(final DataSet original, final DataSet dist, final Set<List<String>> existedRowValues) {
         for (DataSetRow each : original.getRows()) {
+            if (each.getDataNode().contains("broadcast")) {
+                dist.getRows().add(each);
+                continue;
+            }

Review comment:
       It is not a good design for add some concrete codes in the engine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org