You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/11/03 08:58:25 UTC

[GitHub] [drill] jnturton opened a new pull request, #2700: DRILL-8296: Possible type mismatch bug in SplunkBatchReader

jnturton opened a new pull request, #2700:
URL: https://github.com/apache/drill/pull/2700

   # [DRILL-8296](https://issues.apache.org/jira/browse/DRILL-8296): Possible type mismatch bug in SplunkBatchReader
   
   ## Description
   ```
         if (path.nameEquals("**")) {
           return true;
         } else {
           return specialFields.contains(path.getAsNamePart());
         }
   ```
   LGTM and IntelliJ both say that NamePart type does not match the type stored in specialFields collection. This change refactors the code handling special fields.
   
   ## Documentation
   N/A
   
   ## Testing
   Splunk plugin unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton merged pull request #2700: DRILL-8296: Possible type mismatch bug in SplunkBatchReader

Posted by GitBox <gi...@apache.org>.

jnturton merged PR #2700:
URL: https://github.com/apache/drill/pull/2700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org