You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/04 13:27:11 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
francisguchie opened a new pull request #1148:
URL: https://github.com/apache/fineract/pull/1148
## Description
https://issues.apache.org/jira/browse/FINERACT-1054
## Checklist
see https://github.com/apache/fineract/pull/1139
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653922992
re-opened let me observe the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653767958
Your PR is failing Travis. We can only consider to merge PRs when they have passed Travis test and everything is green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653772190
Yes @awasum
Please see how i pull from develop all the time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653769388
Make sure you have pulled from Fineract develop branch. latest changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653767841
See: https://travis-ci.org/github/apache/fineract/builds/704910968
Run './gradlew :spotlessApply' to fix these violations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-654207589
> If #1154 has the final version of what needs to be done, please close this one :)
> @awasum can merge the other PR as soon as we get it reviewed.
" Sir Yes Sir "
Yes the #1154 has the final version
am closing this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653937605
@francisguchie I made a video, it might help you: https://www.loom.com/share/d805d63a44014156a9955dd29b0ee4d5
Spotless took exceptionally 1 min(usually takes 10sec idk why, while making the video)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653934115
@awasum
followed the steps you provided. still PR failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653768779
@awasum
I am using a windows 10 PC - I have run the /gradlew :spotlessApply and it was successful on my computer please see image below and advise. I would love to know how to solve this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653943430
If #1154 has the final version of what needs to be done, please close this one :)
@awasum can merge the other PR as soon as we get it reviewed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653943187
@thesmallstar thanks alot
Since this PR is the same as the https://github.com/apache/fineract/pull/1154 i think this should be closed. Please advise
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653937851
@francisguchie the final change look like this: https://github.com/apache/fineract/compare/develop...thesmallstar:cur43?expand=1
And will make spotless happy :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1148:
URL: https://github.com/apache/fineract/pull/1148#issuecomment-653800661
i will close this and make another PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1148:
URL: https://github.com/apache/fineract/pull/1148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1148: FINERACT-1054 fix Error at Loan Repayment -bad SQL Grammar
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1148:
URL: https://github.com/apache/fineract/pull/1148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org