[GitHub] [spark] Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #26644: [SPARK-30004][SQL] Allow merge UserDefinedType into a native DataType
URL: https://github.com/apache/spark/pull/26644#discussion_r352771008
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala
 ##########
 @@ -287,4 +293,63 @@ class UserDefinedTypeSuite extends QueryTest with SharedSparkSession with Parque
     checkAnswer(spark.createDataFrame(data, schema).selectExpr("typeof(a)"),
       Seq(Row("array<double>")))
   }
+
+  test("Allow merge UserDefinedType into a native DataType") {
 
 Review comment:
   @maropu I'm unable to reproduce the issue without Delta. Since plan Spark does not check schema compatibility on write, I'm unable to implement an end to end integration test. I tried to fix this by taking the union of the two DF's, but this took another branch in the codebase, and it failed on `TypeCoercion`.
   
   Please advise. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org