You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/12/14 02:59:01 UTC
[GitHub] [groovy] eric-milles opened a new pull request #1443: GROOVY-9373 (part 1): rework line numbers for statements
eric-milles opened a new pull request #1443:
URL: https://github.com/apache/groovy/pull/1443
https://issues.apache.org/jira/browse/GROOVY-9373
https://issues.apache.org/jira/browse/GROOVY-9199
https://issues.apache.org/jira/browse/GROOVY-9126
https://issues.apache.org/jira/browse/GROOVY-7647
"do" and "try" should not generate line numbers
instructions after last source line are tied to closing brace
instructions before first source line are tied to opening brace
Writing two `LINENUMBER` instructions in a row is an issue. Given this sequence from `groovy.log.classgen` system property:
```
L1
LINENUMBER 7 L1
L2
LINENUMBER 8 L2
```
If user sets breakpoint on line 8 of source, debugger will not stop because it associates line 7 with whatever instructions come next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 merged pull request #1443: GROOVY-9373 (part 1): rework line numbers for statements
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1443:
URL: https://github.com/apache/groovy/pull/1443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1443: GROOVY-9373 (part 1): rework line numbers for statements
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1443:
URL: https://github.com/apache/groovy/pull/1443#issuecomment-746428224
Merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org