You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by sekimura <gi...@git.apache.org> on 2016/11/22 23:15:07 UTC
[GitHub] trafficserver pull request #1232: TS-4938: Avoid crashes due to NULL vc dere...
GitHub user sekimura opened a pull request:
https://github.com/apache/trafficserver/pull/1232
TS-4938: Avoid crashes due to NULL vc dereferences.
Potentially this could fix TS-5046 SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p)
cherry picked from commit 784e7cc8a91b48b93b57cad27ba403684880969f
Conflicts:
proxy/http/HttpSM.cc
proxy/http/HttpServerSession.h
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sekimura/trafficserver ts-4938-backport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1232
----
commit cb7d71a6b1a0789fe66c424c51f137787a12e70b
Author: Susan Hinrichs <sh...@ieee.org>
Date: 2016-10-06T16:20:08Z
TS-4938: Avoid crashes due to NULL vc dereferences.
One more null check.
Remove server_session null checks. And address James' comments.
clang-format
(cherry picked from commit 784e7cc8a91b48b93b57cad27ba403684880969f)
Conflicts:
proxy/http/HttpSM.cc
proxy/http/HttpServerSession.h
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1232: TS-4938: Avoid crashes due to NULL vc dereference...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1232
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1114/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1232: TS-4938: Avoid crashes due to NULL vc dereference...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1232
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1221/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1232: TS-4938: Avoid crashes due to NULL vc dereference...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1232
Looks good to me. One minor comment, but it was an issue with the original change. So I think the backport is good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1232: TS-4938: Avoid crashes due to NULL vc dereference...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/1232
[approve ci]
@shinrich can you give this a look over and check to see if you think it looks ok as a backport?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1232: TS-4938: Avoid crashes due to NULL vc dere...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/1232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1232: TS-4938: Avoid crashes due to NULL vc dere...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1232#discussion_r89840018
--- Diff: proxy/http/HttpTransact.cc ---
@@ -558,7 +558,8 @@ HttpTransact::BadRequest(State *s)
void
HttpTransact::HandleBlindTunnel(State *s)
{
- bool inbound_transparent_p = s->state_machine->ua_session->get_netvc()->get_is_transparent();
+ NetVConnection *vc = s->state_machine->ua_session->get_netvc();
+ bool inbound_transparent_p = vc->get_is_transparent();
--- End diff --
This change isn't going to protect from a NULL vc dereference. I just double checked through and it is the change that was made on the master branch, so the backport is consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---