You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/29 09:49:03 UTC
[GitHub] [lucene] gsmiller opened a new pull request, #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting
gsmiller opened a new pull request, #929:
URL: https://github.com/apache/lucene/pull/929
### Description (or a Jira issue link if you have one)
Please see: LUCENE-10584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting
Posted by GitBox <gi...@apache.org>.
gsmiller merged PR #929:
URL: https://github.com/apache/lucene/pull/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on a diff in pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting
Posted by GitBox <gi...@apache.org>.
gsmiller commented on code in PR #929:
URL: https://github.com/apache/lucene/pull/929#discussion_r894787988
##########
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##########
@@ -74,7 +74,7 @@ public FacetResult getTopChildren(int topN, String dim, String... path) throws I
@Override
public Number getSpecificValue(String dim, String... path) throws IOException {
- if (path.length != 1) {
+ if (stateConfig.getDimConfig(dim).hierarchical == false && path.length != 1) {
throw new IllegalArgumentException("path must be length=1");
Review Comment:
Good suggestion! Pushed a rev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting
Posted by GitBox <gi...@apache.org>.
gsmiller commented on PR #929:
URL: https://github.com/apache/lucene/pull/929#issuecomment-1140414699
@mdmarshmallow - might be a good one for you to have a look at when you get a minute. Pretty simple change but you've got a lot of context since you added hierarchical dim support to SSDV facets (thanks again!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting
Posted by GitBox <gi...@apache.org>.
mdmarshmallow commented on code in PR #929:
URL: https://github.com/apache/lucene/pull/929#discussion_r894746323
##########
lucene/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java:
##########
@@ -74,7 +74,7 @@ public FacetResult getTopChildren(int topN, String dim, String... path) throws I
@Override
public Number getSpecificValue(String dim, String... path) throws IOException {
- if (path.length != 1) {
+ if (stateConfig.getDimConfig(dim).hierarchical == false && path.length != 1) {
throw new IllegalArgumentException("path must be length=1");
Review Comment:
Maybe we should update this error message? Something like `dim + "is not configured to be hierarchical, path must be length=1"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #929: LUCENE-10584: Properly support #getSpecificValue for hierarchical dims in SSDV faceting
Posted by GitBox <gi...@apache.org>.
gsmiller commented on PR #929:
URL: https://github.com/apache/lucene/pull/929#issuecomment-1156775532
Thanks @mdmarshmallow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org