[jira] [Commented] (ARROW-5754) [C++]Missing override for ~GrpcStreamWriter?

["Kenta Murata (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873833#comment-16873833 ] 

Kenta Murata commented on ARROW-5754:
-------------------------------------

Note that I use XCode 10.12.1.

> [C++]Missing override for ~GrpcStreamWriter?
> --------------------------------------------
>
>                 Key: ARROW-5754
>                 URL: https://issues.apache.org/jira/browse/ARROW-5754
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Kenta Murata
>            Priority: Major
>
> I encountered the following compile error:
> {noformat}
> ../src/arrow/flight/client.cc:244:3: error: '~GrpcStreamWriter' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
>   ~GrpcStreamWriter() = default;
>   ^
> ../src/arrow/flight/client.h:86:27: note: overridden virtual function is here
> class ARROW_FLIGHT_EXPORT FlightStreamWriter : public ipc::RecordBatchWriter {
>                           ^
> {noformat}
> Putting override modifier can resolve this problem.
>  I'll make a pull-request for the change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)