You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2026/09/23 16:02:09 UTC

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24929


Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................

IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header

Removes the extra trailing newline and space in the error_description
key-value par of the WWW-Authenticate http header. This header is
returned when JWT/OAuth auth fails.

Testing accomplished by manually verifing the WWW-Authenticate http
header value using curl and by existing JWT/OAuth custom cluster
tests passing.

Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Assisted-by: GPT-5.3-Codex (Copilot)
---
M be/src/util/oauth-servers-manager.cc
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/24929/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 21:24:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 17:18:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................

IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header

Removes the extra trailing newline and space in the error_description
key-value part of the WWW-Authenticate http header. This header is
returned when JWT/OAuth auth fails.

Testing accomplished by manually verifing the WWW-Authenticate http
header value using curl and by existing JWT/OAuth custom cluster
tests passing.

Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Assisted-by: GPT-5.3-Codex (Copilot)
---
M be/src/util/oauth-servers-manager-test.cc
M be/src/util/oauth-servers-manager.cc
2 files changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/24929/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24245/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 29 Sep 2026 15:37:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24152/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 16:25:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................

IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header

Removes the extra trailing newline and space in the error_description
key-value part of the WWW-Authenticate http header. This header is
returned when JWT/OAuth auth fails.

Testing accomplished by manually verifing the WWW-Authenticate http
header value using curl and by existing JWT/OAuth custom cluster
tests passing.

Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Assisted-by: GPT-5.3-Codex (Copilot)
Reviewed-on: http://gerrit.cloudera.org:8080/24929
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M be/src/util/oauth-servers-manager-test.cc
M be/src/util/oauth-servers-manager.cc
2 files changed, 22 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Michael Smith: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14204/


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 01:48:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24929/3/be/src/util/oauth-servers-manager.cc
File be/src/util/oauth-servers-manager.cc:

http://gerrit.cloudera.org:8080/#/c/24929/3/be/src/util/oauth-servers-manager.cc@39
PS3, Line 39: error_message
Maybe out of scope for this PR, but do we worry about the error_message exposing some info in this header, like the raw claim values? For example in https://gerrit.cloudera.org/#/c/24472/10/be/src/util/jwt-util.cc L109:
 "return Status(TErrorCode::JWT_VERIFY_FAILED, Substitute("Claim '$0' value '$1' is not allowed", claim_name, claim_value.serialize()));".
And we are not sure if future would be other error message from down there, I am thinking would it be safer to log the details in server side instead and return the error code or something static in the header?



-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Sep 2026 03:37:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 4:

Encountered https://issues.apache.org/jira/browse/IMPALA-11572, everything else passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 14:07:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 14:07:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14204/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 21:24:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Oct 2026 21:24:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24929/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24929/2//COMMIT_MSG@10
PS2, Line 10: key-value par of the WWW-Authenticate http header. This header is
small typo: I assume "par" should be "part"



-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 16:10:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15412: Fix Formatting of error description in WWW-Authenticate Header

Posted by "Anubhav Jindal (Code Review)" <ge...@cloudera.org>.
Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24929 )

Change subject: IMPALA-15412: Fix Formatting of error_description in WWW-Authenticate Header
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24929/2/be/src/util/oauth-servers-manager.cc
File be/src/util/oauth-servers-manager.cc:

http://gerrit.cloudera.org:8080/#/c/24929/2/be/src/util/oauth-servers-manager.cc@33
PS2, Line 33:   while (!error_message.empty() && error_message.back() == '\n') {
Nit: can we also trim '\r' here (not just '\n')? If a message ends with CRLF, we'd keep a trailing '\r' in the header value


http://gerrit.cloudera.org:8080/#/c/24929/2/be/src/util/oauth-servers-manager.cc@37
PS2, Line 37:       "error_description=\"$0\"", error_message);
Could we add a small regression unit test in oauth-servers-manager-test.cc that asserts the exact Bearer header has no trailing whitespace/newline when Status::GetDetail() ends with newline(s)?



-- 
To view, visit http://gerrit.cloudera.org:8080/24929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb593c82afca89394560d21c5ad9a5c49ad2a53
Gerrit-Change-Number: 24929
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 25 Sep 2026 14:52:25 +0000
Gerrit-HasComments: Yes