You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jay li (Jira)" <ji...@apache.org> on 2022/04/01 02:12:00 UTC
[jira] [Comment Edited] (FLINK-14998) Remove FileUtils#deletePathIfEmpty
[ https://issues.apache.org/jira/browse/FLINK-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515379#comment-17515379 ]
jay li edited comment on FLINK-14998 at 4/1/22 2:11 AM:
--------------------------------------------------------
Hi [~yunta] thanks i got this ticket , I have two questions to ask.
1 ) I need to create a new branch(fork repo) from master and then submit master to pr after solving this problem?
2) I need remove FileUtils#deletePathIfEmpty code and corresponding unit tests.
was (Author: JIRAUSER287310):
Hi [~yunta] thanks i got this ticket , I have two questions to ask.
1 ) I need to create a new branch from master and then submit master to pr after solving this problem?
2) I need remove FileUtils#deletePathIfEmpty code and corresponding unit tests.
> Remove FileUtils#deletePathIfEmpty
> ----------------------------------
>
> Key: FLINK-14998
> URL: https://issues.apache.org/jira/browse/FLINK-14998
> Project: Flink
> Issue Type: Bug
> Components: FileSystems
> Reporter: Yun Tang
> Assignee: jay li
> Priority: Minor
> Labels: auto-deprioritized-major, starter
> Fix For: 1.16.0
>
>
> With the lesson learned from FLINK-7266, and the refactor of FLINK-8540, method of {{FileUtils#deletePathIfEmpty}} has been totally useless in Flink production code. From my point of view, it's not wise to provide a method with already known high-risk defect in Flink official code. I suggest to remove this part of code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)