You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by zhangminglei <gi...@git.apache.org> on 2017/11/06 09:07:38 UTC
[GitHub] commons-collections pull request #33: [COLLECTIONS-664] Add a class that ext...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/commons-collections/pull/33
[COLLECTIONS-664] Add a class that extend a load method which accept …
…a filename.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/commons-collections COLLECTIONS-664
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-collections/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 3ee56fdce999bcf5164c0339601546c2b9b2cd70
Author: zhangminglei <zm...@163.com>
Date: 2017-11-06T09:06:47Z
[COLLECTIONS-664] Add a class that extend a load method which accept a filename.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/commons-collections/pull/33
Thanks @kinow . I would move this PR to Commons/Configuration. I just not sure which component is the best to put it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/commons-collections/pull/33
Hello, @kinow Thanks for your reply!
- Why Commons Collections?. I am not sure which is the best address I should put it. At the beginning, I created the JIRA under Commons Configuration, like you said at the second point. Then I changed my mind.
- As refers to the file name, yea. I think I should give an appropriate name for it, instead of FileProperties.
- I agree with you at this point, before I did this, I searched for a long time for this functionality in Commons Configuration. But I could not find it.
Yes. I will send a message to dev mail list.
Thanks
Minglei
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/commons-collections/pull/33
Hello, @kinow, Could you please take a look on this PR? Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-collections/pull/33
[](https://coveralls.io/builds/14052842)
Coverage increased (+0.006%) to 86.622% when pulling **3ee56fdce999bcf5164c0339601546c2b9b2cd70 on zhangminglei:COLLECTIONS-664** into **0b1460dadb5934ebeb0c1c6ef79992606cdb91f0 on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/33
Hi @zhangminglei !
Sure. Few questions from reviewing the JIRA ticket and the pull request.
* Why Commons Collections? The SortedProperties uses Java collection classes to sort its keys. But FileProperties doesn't seem to have much to do with Java collections.
* The name of the class doesn't really suggest what it does. Unless there are other use cases, we could be more specific about the class name.
* However, I suspect this code belongs more to the user code, and not really to the low level library. Might be better to update the ticket to Commons Configuration maybe (?), and send a message to the development mailing list in case you don't hear back within some days.
The code is well written, and with tests :-) we just need to review the use case, and which component could host it.
Hope it helps
Bruno
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/commons-collections/pull/33
The CI error seems does not relevant to this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-collections/pull/33
Thanks for the clear response Minglei! And thanks for your contribution. Let's see what others think :+1:
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org