[GitHub] [hadoop] jianghuazhu commented on a change in pull request #3345: HDFS-16189: add config for aliyun oss cname support

[GitBox <gi...@apache.org>]

jianghuazhu commented on a change in pull request #3345:
URL: https://github.com/apache/hadoop/pull/3345#discussion_r697303868



##########
File path: hadoop-tools/hadoop-aliyun/src/main/java/org/apache/hadoop/fs/aliyun/oss/Constants.java
##########
@@ -75,6 +75,10 @@ private Constants() {
       "fs.oss.connection.establish.timeout";
   public static final int ESTABLISH_TIMEOUT_DEFAULT = 50000;
 
+  // cname support
+  public static final String CNAME_SUPPORT_KEY = "fs.oss.cname.support.enabled";
+  public static final boolean DEFAULT_CNAME_SUPPORT = true;

Review comment:
       It might be more reasonable to use "XXXX_XXX_DEFAULT".
   Because this can be consistent with the existing format.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org