You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/11 15:38:20 UTC
[GitHub] [nifi] greyp9 opened a new pull request, #5954: NIFI-9902 - Improve handling of charsets when performing string/byte …
greyp9 opened a new pull request, #5954:
URL: https://github.com/apache/nifi/pull/5954
…conversions
#### Description of PR
Enable project build without specification of `-Dfile.encoding`; additional cases.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #5954: NIFI-9902 - Improve handling of charsets when performing string/byte …
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5954: NIFI-9902 - Improve handling of charsets when performing string/byte …
URL: https://github.com/apache/nifi/pull/5954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #5954: NIFI-9902 - Improve handling of charsets when performing string/byte …
Posted by GitBox <gi...@apache.org>.
greyp9 commented on code in PR #5954:
URL: https://github.com/apache/nifi/pull/5954#discussion_r847467483
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockFlowFile.java:
##########
@@ -272,7 +272,7 @@ public void assertContentEquals(final byte[] data) throws IOException {
}
public void assertContentEquals(final String data) {
- assertContentEquals(data, "UTF-8");
+ assertContentEquals(data, StandardCharsets.UTF_8);
Review Comment:
Skip over the (String, String) method for efficiency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org