[jira] [Commented] (MSHADE-269) Ability to replace also target/classes with modified classes

["Clebert Suconic (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446534#comment-17446534 ] 

Clebert Suconic commented on MSHADE-269:
----------------------------------------

I think this should be closed as explained...

shade creating this sort of dependencies between projects will probably cause more harm than good.


I just been through issues where I was trying to make these sort of things.. and it would work originally but it would become un-manageable in the long term.


after my experience, I think it's a big no to depend on shaded classes within the same project. That's my experience and after an interaction on the maven user's forum.


As for the IDEA-93855 I think they should also close it as won't fix.   this will create more harm than good.


for future reference: https://lists.apache.org/thread/cxg27j5bypdktjhqlzv79z71kt2oqls7

> Ability to replace also target/classes with modified classes
> ------------------------------------------------------------
>
>                 Key: MSHADE-269
>                 URL: https://issues.apache.org/jira/browse/MSHADE-269
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>            Reporter: Ivan Balashov
>            Priority: Major
>
> Relocated classes are only included into artifact jar bypassing module's target / classes directory. IDEs pick up unmodified classes which is undesirable.
> Following the corresponding Intellij Idea Issue:
> [https://youtrack.jetbrains.com/issue/IDEA-93855]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)