You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/05 05:28:14 UTC

[GitHub] [apisix] moonming commented on a change in pull request #2943: feat: support enable/disable route

moonming commented on a change in pull request #2943:
URL: https://github.com/apache/apisix/pull/2943#discussion_r536518238



##########
File path: apisix/http/router/radixtree_host_uri.lua
##########
@@ -95,7 +95,8 @@ local function create_radixtree_router(routes)
 
     for _, route in ipairs(routes or {}) do
         local status = core.table.try_read_attr(route, "value", "status")
-        if status and status ~= 1 then
+        -- check the status
+        if status and status == 0 then

Review comment:
       You should add test cases for it:)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org