You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by GitBox <gi...@apache.org> on 2019/09/26 10:08:09 UTC

[GitHub] [metamodel] arjansh commented on a change in pull request #230: dev/add datatypes to excel columns

arjansh commented on a change in pull request #230: dev/add datatypes to excel columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r328522967
 
 

 ##########
 File path: excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java
 ##########
 @@ -103,9 +104,8 @@ public void notifyTablesModified() {
         // do nothing
     }
 
-    private MutableTable createTable(final Workbook wb, final Sheet sheet) {
+    private MutableTable createTable(Workbook wb, Sheet sheet) {
 
 Review comment:
   Why remove the `final` keywords here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services