You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2015/05/06 08:16:00 UTC

[jira] [Commented] (SLING-4415) :applyTo should not display changeLog (when operation fails)

    [ https://issues.apache.org/jira/browse/SLING-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530005#comment-14530005 ] 

Antonio Sanso commented on SLING-4415:
--------------------------------------

proposed patch 

{code}
Index: src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java
===================================================================
--- src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java	(revision 1675826)
+++ src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java	(working copy)
@@ -212,11 +212,11 @@
      * @return an error or <code>null</code>
      */
     public Throwable getError() {
-        return getProperty(PN_ERROR, Throwable.class);
+        return new Throwable("Exception during response processing.");
     }
 
     public void setError(Throwable error) {
-        setProperty(PN_ERROR, error);
+        //NOTHING TO DO
     }
 
     /**
{code}

> :applyTo should not display changeLog (when operation fails)
> ------------------------------------------------------------
>
>                 Key: SLING-4415
>                 URL: https://issues.apache.org/jira/browse/SLING-4415
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>    Affects Versions: Servlets Post 2.3.6
>            Reporter: Lars Krapf
>            Assignee: Antonio Sanso
>
> When the :applyTo operation fails the change-log leaks information about the internal path-structure even when the requesting session does not have access to these paths. 
> One solution would be to completely omit the ChangeLog (at least when the operation fails), another option would be to make the :sendError behaviour configurable in the POST servlet, so that the error message can be reliably overlaid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)