[GitHub] [flink] zhijiangW commented on a change in pull request #9634: [hotfix][runtime] Streaming runtime 1.9 improvements for dubuggability

[GitBox <gi...@apache.org>]

zhijiangW commented on a change in pull request #9634: [hotfix][runtime] Streaming runtime 1.9 improvements for dubuggability
URL: https://github.com/apache/flink/pull/9634#discussion_r321637542
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
 ##########
 @@ -114,6 +114,7 @@ protected void cleanup() {
 	protected void performDefaultAction(ActionContext context) throws Exception {
 		// Against the usual contract of this method, this implementation is not step-wise but blocking instead for
 		// compatibility reasons with the current source interface (source functions run as a loop, not in steps).
+		sourceThread.setTaskDescription(getName());
 
 Review comment:
   I wonder why not do it via `this.sourceThread = new LegacySourceFunctionThread(getName())` directly in master branch. Then 
   ```
   LegacySourceFunctionThread(String name) {
          super(name);
   }
   ```
   
   Although `performDefaultAction` would be executed only once for source task, it seems better to do it in constructor. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services