You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jobs@airflow.apache.org by GitBox <gi...@apache.org> on 2026/04/28 15:08:13 UTC

[GH] (airflow/registry-backfill-patch-and-guard): Workflow run "Check newsfragment PR number" is working again!

The GitHub Actions job "Check newsfragment PR number" on airflow.git/registry-backfill-patch-and-guard has succeeded.
Run started by GitHub user kaxil (triggered by kaxil).

Head commit for run:
f063da1d8e2652cc83e3ba0a9e05f2ba0d2addd5 / Kaxil Naik <ka...@gmail.com>
Make registry-backfill workflow actually publish backfilled pages

Three related bugs in `.github/workflows/registry-backfill.yml` that
combine to make backfill jobs report success while uploading nothing:

1. **`Download data files from S3 for build` clobbers the in-flight
   `providers.json`.** The workflow downloads the cached S3 copy of
   `providers.json` to `registry/src/_data/providers.json` AFTER
   extraction has run. The cached copy predates the backfilled version,
   so `provider.versions[]` doesn't list it.
   `registry/src/_data/providerVersions.js:48-50` then intersects
   `provider.versions ∩ availableSet` and drops the on-disk
   `metadata.json` for the new version. Eleventy emits no per-version
   page for the backfilled version.

2. **`aws s3 sync` exits 0 on missing source.** Combined with (1), the
   workflow's "Sync backfilled version pages to S3" step silently
   no-ops when the build didn't emit a page, and the job goes green.

3. **A redundant `Extract version metadata from git tags` step
   duplicated `breeze registry backfill`'s internal call AND was broken
   for multi-version matrix entries.** `extract_versions.py:446`
   declared `--version` as single-valued (no `action="append"`), so
   when the workflow looped `--version A --version B` argparse only
   kept the last one. The trailing `|| true` masked the failure.

Fixes:

- New script `dev/registry/patch_providers_json.py` runs after the S3
  download and appends backfilled version(s) into the targeted
  `provider.versions` array. It also defensively keeps `provider.version`
  (the latest) in the array -- otherwise patching into a previously-empty
  list could leave the latest field excluded once the array becomes
  the authoritative filter for `providerVersions.js`.

- Sync step now asserts (a) the per-version `index.html` was emitted,
  (b) the API directory exists, (c) `parameters.json` is non-empty,
  before running each `aws s3 sync`. Silent no-ops are now hard
  failures with `::error::` annotations.

- The redundant standalone `Extract version metadata` step is deleted.
  `breeze registry backfill` already runs `_run_extract_versions`
  internally and propagates exit codes correctly.

`packaging` is now declared as a runtime dep of `dev/registry/`
(previously only available transitively via pydantic) since
`patch_providers_json.py` uses `packaging.version` for newest-first
sorting.

Tests: 11 unit tests in `dev/registry/tests/test_patch_providers_json.py`
covering append, dedup, unknown-provider error, multi-version,
invalid-version sort fallback, empty-list edge (the latest-included
guarantee), latest-field-untouched, other-providers-untouched, and
three CLI invocation paths.

Report URL: https://github.com/apache/airflow/actions/runs/25060968215

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: jobs-unsubscribe@airflow.apache.org
For additional commands, e-mail: jobs-help@airflow.apache.org