You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Hzfengsy (via GitHub)" <gi...@apache.org> on 2023/11/24 09:13:31 UTC

[PR] [Unity][DLight] Fix `general_reduction` for GroupNorm [tvm]

Hzfengsy opened a new pull request, #16161:
URL: https://github.com/apache/tvm/pull/16161

   The pass `lower_thread_allreduce` failed to codegen if the spatial loops are unrolled during the schedule. This PR works around the issue by changing the schedule rules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][DLight] Fix `general_reduction` for GroupNorm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #16161:
URL: https://github.com/apache/tvm/pull/16161#issuecomment-1829916191

   Thank you @Hzfengsy !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][DLight] Fix `general_reduction` for GroupNorm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #16161:
URL: https://github.com/apache/tvm/pull/16161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][DLight] Fix `general_reduction` for GroupNorm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #16161:
URL: https://github.com/apache/tvm/pull/16161#issuecomment-1828626269

   is the update on cutlass submodules intentional? we should revert these then we are good to merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity][DLight] Fix `general_reduction` for GroupNorm [tvm]

Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #16161:
URL: https://github.com/apache/tvm/pull/16161#issuecomment-1828984881

   Thanks for pointing it out. Fixed :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org