You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2008/10/31 17:19:37 UTC

[jira] Created: (TILES-329) Allow re-evaluation of a TilesContextFactory

Allow re-evaluation of a TilesContextFactory
--------------------------------------------

                 Key: TILES-329
                 URL: https://issues.apache.org/struts/browse/TILES-329
             Project: Tiles
          Issue Type: Improvement
          Components: tiles-core, tiles-jsp (jsp support)
    Affects Versions: 2.1.0
            Reporter: Antonio Petrelli
            Assignee: Antonio Petrelli
             Fix For: 2.1.x


JspTilesRequestContext builds itself by wrapping a ServletTilesRequestContext. But in fact, it should "recall" the ChainedTilesContextFactory to construct a TilesRequestContext using the HTTP request and the HTTP response. This to allow the correct customization of creation of a TilesRequestContext that accept these two parameters.
A mechanism that allows the re-evaluation of the "parent" TilesContextFactory should be provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TILES-329) Allow re-evaluation of a TilesContextFactory

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli resolved TILES-329.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.1.x)
                   2.1.1

TilesContextFactory now is re-evaluated by passing the parent TilesContextFactory to all children, in particular from a ChainedTilesContextFactory to all elements of the chain.
Modified JspTilesContextFactory accordingly.

> Allow re-evaluation of a TilesContextFactory
> --------------------------------------------
>
>                 Key: TILES-329
>                 URL: https://issues.apache.org/struts/browse/TILES-329
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-core, tiles-jsp (jsp support)
>    Affects Versions: 2.1.0
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.1
>
>
> JspTilesRequestContext builds itself by wrapping a ServletTilesRequestContext. But in fact, it should "recall" the ChainedTilesContextFactory to construct a TilesRequestContext using the HTTP request and the HTTP response. This to allow the correct customization of creation of a TilesRequestContext that accept these two parameters.
> A mechanism that allows the re-evaluation of the "parent" TilesContextFactory should be provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TILES-329) Allow re-evaluation of a TilesContextFactory

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli resolved TILES-329.
------------------------------------

    Resolution: Fixed

Removed self-injection from ChainedTilesContextFactory when using setFactories.

> Allow re-evaluation of a TilesContextFactory
> --------------------------------------------
>
>                 Key: TILES-329
>                 URL: https://issues.apache.org/struts/browse/TILES-329
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-core, tiles-jsp (jsp support)
>    Affects Versions: 2.1.0
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.1
>
>
> JspTilesRequestContext builds itself by wrapping a ServletTilesRequestContext. But in fact, it should "recall" the ChainedTilesContextFactory to construct a TilesRequestContext using the HTTP request and the HTTP response. This to allow the correct customization of creation of a TilesRequestContext that accept these two parameters.
> A mechanism that allows the re-evaluation of the "parent" TilesContextFactory should be provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (TILES-329) Allow re-evaluation of a TilesContextFactory

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli reopened TILES-329:
------------------------------------


I reopen the issue because I made a "self injection" instead of making injection available from the outside.

> Allow re-evaluation of a TilesContextFactory
> --------------------------------------------
>
>                 Key: TILES-329
>                 URL: https://issues.apache.org/struts/browse/TILES-329
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-core, tiles-jsp (jsp support)
>    Affects Versions: 2.1.0
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.1
>
>
> JspTilesRequestContext builds itself by wrapping a ServletTilesRequestContext. But in fact, it should "recall" the ChainedTilesContextFactory to construct a TilesRequestContext using the HTTP request and the HTTP response. This to allow the correct customization of creation of a TilesRequestContext that accept these two parameters.
> A mechanism that allows the re-evaluation of the "parent" TilesContextFactory should be provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (TILES-329) Allow re-evaluation of a TilesContextFactory

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/TILES-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli closed TILES-329.
----------------------------------


Closed due to the release of Tiles 2.1.1

> Allow re-evaluation of a TilesContextFactory
> --------------------------------------------
>
>                 Key: TILES-329
>                 URL: https://issues.apache.org/struts/browse/TILES-329
>             Project: Tiles
>          Issue Type: Improvement
>          Components: tiles-core, tiles-jsp (jsp support)
>    Affects Versions: 2.1.0
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>             Fix For: 2.1.1
>
>
> JspTilesRequestContext builds itself by wrapping a ServletTilesRequestContext. But in fact, it should "recall" the ChainedTilesContextFactory to construct a TilesRequestContext using the HTTP request and the HTTP response. This to allow the correct customization of creation of a TilesRequestContext that accept these two parameters.
> A mechanism that allows the re-evaluation of the "parent" TilesContextFactory should be provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.