You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Stephane Nicoll <st...@gmail.com> on 2011/03/14 09:22:46 UTC
Include maven-car-plugin to the official maven plugins
Hi,
I am currently working on supporting the "application-client" artifact
type properly in the EAR plugin. Pablo (in CC) wrote a
maven-car-plugin[1] which is very similar to the EJB plugin but for
application-client type. Do we think it would be reasonable to add
this plugin to the portfolio of standard plugins? (if Pablo accepts to
contribute it to the ASF but I don't think it would be an issue).
I am bit puzzled about the type 'car' since car is already used by
Geronimo for their deployment plans; <type>application-client</type>
would better fit I'd say (with a .jar extension)
The problems I am having is that since we don't have an "official"
maven type for that thing and nothing to build it with Maven, I can't
detect these artifacts other than scanning every single jar file added
to a project to see if there is a META-INF/application-client.xml
file. Frankly, I am not going to implement a feature that will scan
every single jar file before building an EAR
The plugin needs a bit of cleanup (namely the jEE version check) and I
don't know if the community uses this a lot but we don't cover the
whole spectrum of the JavaEE spec and it wouldn't cost us much to do
it.
Can someone remind me how these "official" types gets added and
detected by Maven? Do we absolutely need to touch the core type
definition files or is there another way?
Please let me know what you think.
Thanks,
S.
[1] http://code.google.com/p/maven-car-plugin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
Hi,
The plugin seems to be ready to be released and I'd like to get your
feedback and make sure we are on the same page.
# The plugin is released as 1.0 with its components.xml
# The maven ear plugin is updated to deal with this new packaging type and a
set of its are added, relying on this plugin (<extensions>true</extensions>)
# The artifacts-handlers file of Maven core is updated to take care of this
new packaging type[1]
Does that make sense? I've not found any other plugin that has a lifecycle
for a packaging type. I have no idea how this works and if, for instance, a
conflict might occur if someone enable the extensions of the
maven-acr-plugin with the upcoming maven 3.0.4 ?
I will call for a release as soon as I am done with documentation
Thanks,
Stéphane
[1]
http://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml
On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
<st...@gmail.com>wrote:
> Hi,
>
> I am currently working on supporting the "application-client" artifact
> type properly in the EAR plugin. Pablo (in CC) wrote a
> maven-car-plugin[1] which is very similar to the EJB plugin but for
> application-client type. Do we think it would be reasonable to add
> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> contribute it to the ASF but I don't think it would be an issue).
>
> I am bit puzzled about the type 'car' since car is already used by
> Geronimo for their deployment plans; <type>application-client</type>
> would better fit I'd say (with a .jar extension)
>
> The problems I am having is that since we don't have an "official"
> maven type for that thing and nothing to build it with Maven, I can't
> detect these artifacts other than scanning every single jar file added
> to a project to see if there is a META-INF/application-client.xml
> file. Frankly, I am not going to implement a feature that will scan
> every single jar file before building an EAR
>
> The plugin needs a bit of cleanup (namely the jEE version check) and I
> don't know if the community uses this a lot but we don't cover the
> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> it.
>
> Can someone remind me how these "official" types gets added and
> detected by Maven? Do we absolutely need to touch the core type
> definition files or is there another way?
>
> Please let me know what you think.
>
> Thanks,
> S.
>
> [1] http://code.google.com/p/maven-car-plugin
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Pablo <pa...@anahata-it.com>.
Hi,
In reply to Stephane:
On 03/14/2011 04:22 PM, Stephane Nicoll wrote:
> Hi,
>
> I am currently working on supporting the "application-client" artifact
> type properly in the EAR plugin. Pablo (in CC) wrote a
> maven-car-plugin[1] which is very similar to the EJB plugin but for
> application-client type. Do we think it would be reasonable to add
> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> contribute it to the ASF but I don't think it would be an issue).
I am more than happy to donate the plugin to the ASF and to help in
whichever way is needed.
> I am bit puzzled about the type 'car' since car is already used by
> Geronimo for their deployment plans;<type>application-client</type>
> would better fit I'd say (with a .jar extension)
Yes, i think either
<type>application-client</type>
or
<type>app-client</type>
would be fine. Probably more self explanatory than 'car'.
And yesm once packaged, the file must have .jar extension, this is what
app servers expect.
We could then rename the plugin to maven-application-client-plugin or
*maven-app-client-plugin* if that made it more clear.
> The problems I am having is that since we don't have an "official"
> maven type for that thing and nothing to build it with Maven, I can't
> detect these artifacts other than scanning every single jar file added
> to a project to see if there is a META-INF/application-client.xml
> file. Frankly, I am not going to implement a feature that will scan
> every single jar file before building an EAR
I don't think scanning every jar is a good idea either, doesn't take
much effor to add <type>app-client</type> in the ear's pom
> The plugin needs a bit of cleanup (namely the jEE version check) and I
> don't know if the community uses this a lot but we don't cover the
> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> it.
I am sure it will not get as used as ejb, war or ear plugin but i think
it will get more used than 'rar' . And yes, agree in the point that
being defined in the JEE spec we should be implementing it.
> Can someone remind me how these "official" types gets added and
> detected by Maven? Do we absolutely need to touch the core type
> definition files or is there another way?
To my knowledge, defining a packaging type and artifact handler inside a
plugin (Meta-INF/plexus/components.xml) only makes it visible if you add
the plugin as a dependency. This means that we would have to add
maven-app-client-plugin as a dependency to maven-ear-plugin and the ear
projects. No good. I vote for adding it to the core type definition
files and give it the exact same status as rar,war,ejb,ear, etc.
> Please let me know what you think.
>
> Thanks,
> S.
>
> [1] http://code.google.com/p/maven-car-plugin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Pablo Rodriguez Pina
Director
Anahata Technologies PTY LTD
Phone 04 1091 5078
E-mail pablo@anahata-it.com <ma...@anahata-it.com>
Web anahata-it.com <http://www.anahata-it.com>
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
Yes acr was what I was looking for. If nobody has any objection with that I
will rework the plugin Pablo gave me and include it in the official plugins
list.
Thanks,
Stéphane
On Sat, Mar 19, 2011 at 9:42 AM, Olivier Lamy <ol...@apache.org> wrote:
> Hi,
> No problem for me if you want to add this new packaging support and
> add in maven core.
>
> acr ?
>
> --
> Olivier
>
> 2011/3/19 Stephane Nicoll <st...@gmail.com>:
> > No Maven committers/PMCs replied to this.
> >
> > Any insight?
> >
> > S.
> >
> > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> > <st...@gmail.com>wrote:
> >
> >> Hi,
> >>
> >> I am currently working on supporting the "application-client" artifact
> >> type properly in the EAR plugin. Pablo (in CC) wrote a
> >> maven-car-plugin[1] which is very similar to the EJB plugin but for
> >> application-client type. Do we think it would be reasonable to add
> >> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> >> contribute it to the ASF but I don't think it would be an issue).
> >>
> >> I am bit puzzled about the type 'car' since car is already used by
> >> Geronimo for their deployment plans; <type>application-client</type>
> >> would better fit I'd say (with a .jar extension)
> >>
> >> The problems I am having is that since we don't have an "official"
> >> maven type for that thing and nothing to build it with Maven, I can't
> >> detect these artifacts other than scanning every single jar file added
> >> to a project to see if there is a META-INF/application-client.xml
> >> file. Frankly, I am not going to implement a feature that will scan
> >> every single jar file before building an EAR
> >>
> >> The plugin needs a bit of cleanup (namely the jEE version check) and I
> >> don't know if the community uses this a lot but we don't cover the
> >> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> >> it.
> >>
> >> Can someone remind me how these "official" types gets added and
> >> detected by Maven? Do we absolutely need to touch the core type
> >> definition files or is there another way?
> >>
> >> Please let me know what you think.
> >>
> >> Thanks,
> >> S.
> >>
> >> [1] http://code.google.com/p/maven-car-plugin
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Arnaud Héritier <ar...@exoplatform.com>.
ok for me too.
Arnaud
On Sat, Mar 19, 2011 at 10:04 AM, Kristian Rosenvold
<kr...@gmail.com> wrote:
> Sorry, my misunderstanding.
>
> Looks good to me ;)
>
> Kristian
>
>
>
> lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
>> What other code are you talking about? The plugin on google code? The idea
>> here is to deprecate it in favor of this "official" maven plugin
>>
>> S.
>>
>> On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
>> kristian.rosenvold@gmail.com> wrote:
>>
>> > Just out of curiosity, how does this code relate to the other code that
>> > does similar stuff? Is it a copy paste fork?
>> >
>> > Kristian
>> >
>> > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
>> > > Hi,
>> > > No problem for me if you want to add this new packaging support and
>> > > add in maven core.
>> > >
>> > > acr ?
>> > >
>> > > --
>> > > Olivier
>> > >
>> > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
>> > > > No Maven committers/PMCs replied to this.
>> > > >
>> > > > Any insight?
>> > > >
>> > > > S.
>> > > >
>> > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
>> > > > <st...@gmail.com>wrote:
>> > > >
>> > > >> Hi,
>> > > >>
>> > > >> I am currently working on supporting the "application-client" artifact
>> > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
>> > > >> maven-car-plugin[1] which is very similar to the EJB plugin but for
>> > > >> application-client type. Do we think it would be reasonable to add
>> > > >> this plugin to the portfolio of standard plugins? (if Pablo accepts to
>> > > >> contribute it to the ASF but I don't think it would be an issue).
>> > > >>
>> > > >> I am bit puzzled about the type 'car' since car is already used by
>> > > >> Geronimo for their deployment plans; <type>application-client</type>
>> > > >> would better fit I'd say (with a .jar extension)
>> > > >>
>> > > >> The problems I am having is that since we don't have an "official"
>> > > >> maven type for that thing and nothing to build it with Maven, I can't
>> > > >> detect these artifacts other than scanning every single jar file added
>> > > >> to a project to see if there is a META-INF/application-client.xml
>> > > >> file. Frankly, I am not going to implement a feature that will scan
>> > > >> every single jar file before building an EAR
>> > > >>
>> > > >> The plugin needs a bit of cleanup (namely the jEE version check) and I
>> > > >> don't know if the community uses this a lot but we don't cover the
>> > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
>> > > >> it.
>> > > >>
>> > > >> Can someone remind me how these "official" types gets added and
>> > > >> detected by Maven? Do we absolutely need to touch the core type
>> > > >> definition files or is there another way?
>> > > >>
>> > > >> Please let me know what you think.
>> > > >>
>> > > >> Thanks,
>> > > >> S.
>> > > >>
>> > > >> [1] http://code.google.com/p/maven-car-plugin
>> > > >>
>> > > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > For additional commands, e-mail: dev-help@maven.apache.org
>> > >
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>> >
>> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
No that's fine, Brett created it. Thank you Brett!
I added a first version of the plugin[2]
Thanks,
S.
[1] http://jira.codehaus.org/browse/MACR
[2] https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-acr-plugin/
2011/3/20 Stephen Connolly <st...@gmail.com>
> Yeah, I'll pester ben on tuesday and see if we can get a couple more PMCs
> with admin rights (AFAIK Brett is the only one)
>
>
> 2011/3/19 Arnaud Héritier <ar...@exoplatform.com>
>
>> I lost my admin rights a long time ago and I'm not sure there are
>> always codehaus jira admins here ?
>> The best is to contact ben on IRC or by opening a HAUS issue
>>
>> Cheers
>>
>> Arnaud
>>
>> On Sat, Mar 19, 2011 at 9:19 PM, Stephane Nicoll
>> <st...@gmail.com> wrote:
>> > okay I have a candidate implementation based on the initial plugin on
>> google
>> > code.
>> >
>> > Can someone with Jira admin right create the maven project for the
>> plugin
>> > please?
>> > http://jira.codehaus.org/browse/MPA-116
>> >
>> > Thanks,
>> > Stéphane
>> >
>> > On Sat, Mar 19, 2011 at 10:04 AM, Kristian Rosenvold <
>> > kristian.rosenvold@gmail.com> wrote:
>> >
>> >> Sorry, my misunderstanding.
>> >>
>> >> Looks good to me ;)
>> >>
>> >> Kristian
>> >>
>> >>
>> >>
>> >> lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
>> >> > What other code are you talking about? The plugin on google code? The
>> >> idea
>> >> > here is to deprecate it in favor of this "official" maven plugin
>> >> >
>> >> > S.
>> >> >
>> >> > On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
>> >> > kristian.rosenvold@gmail.com> wrote:
>> >> >
>> >> > > Just out of curiosity, how does this code relate to the other code
>> that
>> >> > > does similar stuff? Is it a copy paste fork?
>> >> > >
>> >> > > Kristian
>> >> > >
>> >> > > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
>> >> > > > Hi,
>> >> > > > No problem for me if you want to add this new packaging support
>> and
>> >> > > > add in maven core.
>> >> > > >
>> >> > > > acr ?
>> >> > > >
>> >> > > > --
>> >> > > > Olivier
>> >> > > >
>> >> > > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
>> >> > > > > No Maven committers/PMCs replied to this.
>> >> > > > >
>> >> > > > > Any insight?
>> >> > > > >
>> >> > > > > S.
>> >> > > > >
>> >> > > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
>> >> > > > > <st...@gmail.com>wrote:
>> >> > > > >
>> >> > > > >> Hi,
>> >> > > > >>
>> >> > > > >> I am currently working on supporting the "application-client"
>> >> artifact
>> >> > > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
>> >> > > > >> maven-car-plugin[1] which is very similar to the EJB plugin
>> but
>> >> for
>> >> > > > >> application-client type. Do we think it would be reasonable to
>> add
>> >> > > > >> this plugin to the portfolio of standard plugins? (if Pablo
>> >> accepts to
>> >> > > > >> contribute it to the ASF but I don't think it would be an
>> issue).
>> >> > > > >>
>> >> > > > >> I am bit puzzled about the type 'car' since car is already
>> used by
>> >> > > > >> Geronimo for their deployment plans;
>> >> <type>application-client</type>
>> >> > > > >> would better fit I'd say (with a .jar extension)
>> >> > > > >>
>> >> > > > >> The problems I am having is that since we don't have an
>> "official"
>> >> > > > >> maven type for that thing and nothing to build it with Maven,
>> I
>> >> can't
>> >> > > > >> detect these artifacts other than scanning every single jar
>> file
>> >> added
>> >> > > > >> to a project to see if there is a
>> META-INF/application-client.xml
>> >> > > > >> file. Frankly, I am not going to implement a feature that will
>> >> scan
>> >> > > > >> every single jar file before building an EAR
>> >> > > > >>
>> >> > > > >> The plugin needs a bit of cleanup (namely the jEE version
>> check)
>> >> and I
>> >> > > > >> don't know if the community uses this a lot but we don't cover
>> the
>> >> > > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much
>> to
>> >> do
>> >> > > > >> it.
>> >> > > > >>
>> >> > > > >> Can someone remind me how these "official" types gets added
>> and
>> >> > > > >> detected by Maven? Do we absolutely need to touch the core
>> type
>> >> > > > >> definition files or is there another way?
>> >> > > > >>
>> >> > > > >> Please let me know what you think.
>> >> > > > >>
>> >> > > > >> Thanks,
>> >> > > > >> S.
>> >> > > > >>
>> >> > > > >> [1] http://code.google.com/p/maven-car-plugin
>> >> > > > >>
>> >> > > > >
>> >> > > >
>> >> > > >
>> ---------------------------------------------------------------------
>> >> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > > > For additional commands, e-mail: dev-help@maven.apache.org
>> >> > > >
>> >> > >
>> >> > >
>> >> > >
>> >> > >
>> ---------------------------------------------------------------------
>> >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > > For additional commands, e-mail: dev-help@maven.apache.org
>> >> > >
>> >> > >
>> >>
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephen Connolly <st...@gmail.com>.
FYI Ben has granted Arnaud & I jira admin access also. so we should have a
bit more redundancy now
-Stephen
2011/3/20 Stephen Connolly <st...@gmail.com>
> Yeah, I'll pester ben on tuesday and see if we can get a couple more PMCs
> with admin rights (AFAIK Brett is the only one)
>
>
> 2011/3/19 Arnaud Héritier <ar...@exoplatform.com>
>
>> I lost my admin rights a long time ago and I'm not sure there are
>> always codehaus jira admins here ?
>> The best is to contact ben on IRC or by opening a HAUS issue
>>
>> Cheers
>>
>> Arnaud
>>
>> On Sat, Mar 19, 2011 at 9:19 PM, Stephane Nicoll
>> <st...@gmail.com> wrote:
>> > okay I have a candidate implementation based on the initial plugin on
>> google
>> > code.
>> >
>> > Can someone with Jira admin right create the maven project for the
>> plugin
>> > please?
>> > http://jira.codehaus.org/browse/MPA-116
>> >
>> > Thanks,
>> > Stéphane
>> >
>> > On Sat, Mar 19, 2011 at 10:04 AM, Kristian Rosenvold <
>> > kristian.rosenvold@gmail.com> wrote:
>> >
>> >> Sorry, my misunderstanding.
>> >>
>> >> Looks good to me ;)
>> >>
>> >> Kristian
>> >>
>> >>
>> >>
>> >> lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
>> >> > What other code are you talking about? The plugin on google code? The
>> >> idea
>> >> > here is to deprecate it in favor of this "official" maven plugin
>> >> >
>> >> > S.
>> >> >
>> >> > On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
>> >> > kristian.rosenvold@gmail.com> wrote:
>> >> >
>> >> > > Just out of curiosity, how does this code relate to the other code
>> that
>> >> > > does similar stuff? Is it a copy paste fork?
>> >> > >
>> >> > > Kristian
>> >> > >
>> >> > > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
>> >> > > > Hi,
>> >> > > > No problem for me if you want to add this new packaging support
>> and
>> >> > > > add in maven core.
>> >> > > >
>> >> > > > acr ?
>> >> > > >
>> >> > > > --
>> >> > > > Olivier
>> >> > > >
>> >> > > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
>> >> > > > > No Maven committers/PMCs replied to this.
>> >> > > > >
>> >> > > > > Any insight?
>> >> > > > >
>> >> > > > > S.
>> >> > > > >
>> >> > > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
>> >> > > > > <st...@gmail.com>wrote:
>> >> > > > >
>> >> > > > >> Hi,
>> >> > > > >>
>> >> > > > >> I am currently working on supporting the "application-client"
>> >> artifact
>> >> > > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
>> >> > > > >> maven-car-plugin[1] which is very similar to the EJB plugin
>> but
>> >> for
>> >> > > > >> application-client type. Do we think it would be reasonable to
>> add
>> >> > > > >> this plugin to the portfolio of standard plugins? (if Pablo
>> >> accepts to
>> >> > > > >> contribute it to the ASF but I don't think it would be an
>> issue).
>> >> > > > >>
>> >> > > > >> I am bit puzzled about the type 'car' since car is already
>> used by
>> >> > > > >> Geronimo for their deployment plans;
>> >> <type>application-client</type>
>> >> > > > >> would better fit I'd say (with a .jar extension)
>> >> > > > >>
>> >> > > > >> The problems I am having is that since we don't have an
>> "official"
>> >> > > > >> maven type for that thing and nothing to build it with Maven,
>> I
>> >> can't
>> >> > > > >> detect these artifacts other than scanning every single jar
>> file
>> >> added
>> >> > > > >> to a project to see if there is a
>> META-INF/application-client.xml
>> >> > > > >> file. Frankly, I am not going to implement a feature that will
>> >> scan
>> >> > > > >> every single jar file before building an EAR
>> >> > > > >>
>> >> > > > >> The plugin needs a bit of cleanup (namely the jEE version
>> check)
>> >> and I
>> >> > > > >> don't know if the community uses this a lot but we don't cover
>> the
>> >> > > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much
>> to
>> >> do
>> >> > > > >> it.
>> >> > > > >>
>> >> > > > >> Can someone remind me how these "official" types gets added
>> and
>> >> > > > >> detected by Maven? Do we absolutely need to touch the core
>> type
>> >> > > > >> definition files or is there another way?
>> >> > > > >>
>> >> > > > >> Please let me know what you think.
>> >> > > > >>
>> >> > > > >> Thanks,
>> >> > > > >> S.
>> >> > > > >>
>> >> > > > >> [1] http://code.google.com/p/maven-car-plugin
>> >> > > > >>
>> >> > > > >
>> >> > > >
>> >> > > >
>> ---------------------------------------------------------------------
>> >> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > > > For additional commands, e-mail: dev-help@maven.apache.org
>> >> > > >
>> >> > >
>> >> > >
>> >> > >
>> >> > >
>> ---------------------------------------------------------------------
>> >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> > > For additional commands, e-mail: dev-help@maven.apache.org
>> >> > >
>> >> > >
>> >>
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephen Connolly <st...@gmail.com>.
Yeah, I'll pester ben on tuesday and see if we can get a couple more PMCs
with admin rights (AFAIK Brett is the only one)
2011/3/19 Arnaud Héritier <ar...@exoplatform.com>
> I lost my admin rights a long time ago and I'm not sure there are
> always codehaus jira admins here ?
> The best is to contact ben on IRC or by opening a HAUS issue
>
> Cheers
>
> Arnaud
>
> On Sat, Mar 19, 2011 at 9:19 PM, Stephane Nicoll
> <st...@gmail.com> wrote:
> > okay I have a candidate implementation based on the initial plugin on
> google
> > code.
> >
> > Can someone with Jira admin right create the maven project for the plugin
> > please?
> > http://jira.codehaus.org/browse/MPA-116
> >
> > Thanks,
> > Stéphane
> >
> > On Sat, Mar 19, 2011 at 10:04 AM, Kristian Rosenvold <
> > kristian.rosenvold@gmail.com> wrote:
> >
> >> Sorry, my misunderstanding.
> >>
> >> Looks good to me ;)
> >>
> >> Kristian
> >>
> >>
> >>
> >> lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
> >> > What other code are you talking about? The plugin on google code? The
> >> idea
> >> > here is to deprecate it in favor of this "official" maven plugin
> >> >
> >> > S.
> >> >
> >> > On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
> >> > kristian.rosenvold@gmail.com> wrote:
> >> >
> >> > > Just out of curiosity, how does this code relate to the other code
> that
> >> > > does similar stuff? Is it a copy paste fork?
> >> > >
> >> > > Kristian
> >> > >
> >> > > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
> >> > > > Hi,
> >> > > > No problem for me if you want to add this new packaging support
> and
> >> > > > add in maven core.
> >> > > >
> >> > > > acr ?
> >> > > >
> >> > > > --
> >> > > > Olivier
> >> > > >
> >> > > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
> >> > > > > No Maven committers/PMCs replied to this.
> >> > > > >
> >> > > > > Any insight?
> >> > > > >
> >> > > > > S.
> >> > > > >
> >> > > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> >> > > > > <st...@gmail.com>wrote:
> >> > > > >
> >> > > > >> Hi,
> >> > > > >>
> >> > > > >> I am currently working on supporting the "application-client"
> >> artifact
> >> > > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
> >> > > > >> maven-car-plugin[1] which is very similar to the EJB plugin but
> >> for
> >> > > > >> application-client type. Do we think it would be reasonable to
> add
> >> > > > >> this plugin to the portfolio of standard plugins? (if Pablo
> >> accepts to
> >> > > > >> contribute it to the ASF but I don't think it would be an
> issue).
> >> > > > >>
> >> > > > >> I am bit puzzled about the type 'car' since car is already used
> by
> >> > > > >> Geronimo for their deployment plans;
> >> <type>application-client</type>
> >> > > > >> would better fit I'd say (with a .jar extension)
> >> > > > >>
> >> > > > >> The problems I am having is that since we don't have an
> "official"
> >> > > > >> maven type for that thing and nothing to build it with Maven, I
> >> can't
> >> > > > >> detect these artifacts other than scanning every single jar
> file
> >> added
> >> > > > >> to a project to see if there is a
> META-INF/application-client.xml
> >> > > > >> file. Frankly, I am not going to implement a feature that will
> >> scan
> >> > > > >> every single jar file before building an EAR
> >> > > > >>
> >> > > > >> The plugin needs a bit of cleanup (namely the jEE version
> check)
> >> and I
> >> > > > >> don't know if the community uses this a lot but we don't cover
> the
> >> > > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much
> to
> >> do
> >> > > > >> it.
> >> > > > >>
> >> > > > >> Can someone remind me how these "official" types gets added and
> >> > > > >> detected by Maven? Do we absolutely need to touch the core type
> >> > > > >> definition files or is there another way?
> >> > > > >>
> >> > > > >> Please let me know what you think.
> >> > > > >>
> >> > > > >> Thanks,
> >> > > > >> S.
> >> > > > >>
> >> > > > >> [1] http://code.google.com/p/maven-car-plugin
> >> > > > >>
> >> > > > >
> >> > > >
> >> > > >
> ---------------------------------------------------------------------
> >> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > > > For additional commands, e-mail: dev-help@maven.apache.org
> >> > > >
> >> > >
> >> > >
> >> > >
> >> > >
> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > > For additional commands, e-mail: dev-help@maven.apache.org
> >> > >
> >> > >
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Arnaud Héritier <ar...@exoplatform.com>.
I lost my admin rights a long time ago and I'm not sure there are
always codehaus jira admins here ?
The best is to contact ben on IRC or by opening a HAUS issue
Cheers
Arnaud
On Sat, Mar 19, 2011 at 9:19 PM, Stephane Nicoll
<st...@gmail.com> wrote:
> okay I have a candidate implementation based on the initial plugin on google
> code.
>
> Can someone with Jira admin right create the maven project for the plugin
> please?
> http://jira.codehaus.org/browse/MPA-116
>
> Thanks,
> Stéphane
>
> On Sat, Mar 19, 2011 at 10:04 AM, Kristian Rosenvold <
> kristian.rosenvold@gmail.com> wrote:
>
>> Sorry, my misunderstanding.
>>
>> Looks good to me ;)
>>
>> Kristian
>>
>>
>>
>> lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
>> > What other code are you talking about? The plugin on google code? The
>> idea
>> > here is to deprecate it in favor of this "official" maven plugin
>> >
>> > S.
>> >
>> > On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
>> > kristian.rosenvold@gmail.com> wrote:
>> >
>> > > Just out of curiosity, how does this code relate to the other code that
>> > > does similar stuff? Is it a copy paste fork?
>> > >
>> > > Kristian
>> > >
>> > > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
>> > > > Hi,
>> > > > No problem for me if you want to add this new packaging support and
>> > > > add in maven core.
>> > > >
>> > > > acr ?
>> > > >
>> > > > --
>> > > > Olivier
>> > > >
>> > > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
>> > > > > No Maven committers/PMCs replied to this.
>> > > > >
>> > > > > Any insight?
>> > > > >
>> > > > > S.
>> > > > >
>> > > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
>> > > > > <st...@gmail.com>wrote:
>> > > > >
>> > > > >> Hi,
>> > > > >>
>> > > > >> I am currently working on supporting the "application-client"
>> artifact
>> > > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
>> > > > >> maven-car-plugin[1] which is very similar to the EJB plugin but
>> for
>> > > > >> application-client type. Do we think it would be reasonable to add
>> > > > >> this plugin to the portfolio of standard plugins? (if Pablo
>> accepts to
>> > > > >> contribute it to the ASF but I don't think it would be an issue).
>> > > > >>
>> > > > >> I am bit puzzled about the type 'car' since car is already used by
>> > > > >> Geronimo for their deployment plans;
>> <type>application-client</type>
>> > > > >> would better fit I'd say (with a .jar extension)
>> > > > >>
>> > > > >> The problems I am having is that since we don't have an "official"
>> > > > >> maven type for that thing and nothing to build it with Maven, I
>> can't
>> > > > >> detect these artifacts other than scanning every single jar file
>> added
>> > > > >> to a project to see if there is a META-INF/application-client.xml
>> > > > >> file. Frankly, I am not going to implement a feature that will
>> scan
>> > > > >> every single jar file before building an EAR
>> > > > >>
>> > > > >> The plugin needs a bit of cleanup (namely the jEE version check)
>> and I
>> > > > >> don't know if the community uses this a lot but we don't cover the
>> > > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much to
>> do
>> > > > >> it.
>> > > > >>
>> > > > >> Can someone remind me how these "official" types gets added and
>> > > > >> detected by Maven? Do we absolutely need to touch the core type
>> > > > >> definition files or is there another way?
>> > > > >>
>> > > > >> Please let me know what you think.
>> > > > >>
>> > > > >> Thanks,
>> > > > >> S.
>> > > > >>
>> > > > >> [1] http://code.google.com/p/maven-car-plugin
>> > > > >>
>> > > > >
>> > > >
>> > > > ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > > For additional commands, e-mail: dev-help@maven.apache.org
>> > > >
>> > >
>> > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > > For additional commands, e-mail: dev-help@maven.apache.org
>> > >
>> > >
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
Truth be told I took almost nothing from the original plugin except
something I would have done myself if I had to do it. I don't want to
diminish Pablo's contribution of course but I'd say the most important here
was to propose and provide a showcase that helps up supporting the whole
JavaEE spectrum.
Now, if we need to go through IP clearance let's do it of course!
I have also the necessary changes in the EAR plugin to support this use case
so we're good to go as soon as the jira project is created.
S.
On Sun, Mar 20, 2011 at 4:14 AM, Pablo <pa...@anahata-it.com> wrote:
> Wendy,
>
> I wrote the google code plugin, based on Stephane's maven-ejb-plugin.
>
> In google code i licenced it under Apache License 2.0. And all source files
> contain the apache licence. But if there is anything i need to do to give
> full more ip clearance let me know and i'll do it straight away.
>
> Regards,
> Pablo.
>
>
>
> On 03/20/2011 08:12 AM, Wendy Smoak wrote:
>
> On Sat, Mar 19, 2011 at 4:19 PM, Stephane Nicoll<st...@gmail.com> <st...@gmail.com> wrote:
>
>
> okay I have a candidate implementation based on the initial plugin on google
> code.
>
> How big of a contribution is it? Does it need to go through the IP
> clearance process?http://incubator.apache.org/ip-clearance/index.html
>
>
>
> --
> Pablo Rodriguez Pina
> Director
> Anahata Technologies PTY LTD
> Phone 04 1091 5078
> E-mail pablo@anahata-it.com
> Web anahata-it.com <http://www.anahata-it.com>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Pablo <pa...@anahata-it.com>.
Wendy,
I wrote the google code plugin, based on Stephane's maven-ejb-plugin.
In google code i licenced it under Apache License 2.0. And all source
files contain the apache licence. But if there is anything i need to do
to give full more ip clearance let me know and i'll do it straight away.
Regards,
Pablo.
On 03/20/2011 08:12 AM, Wendy Smoak wrote:
> On Sat, Mar 19, 2011 at 4:19 PM, Stephane Nicoll
> <st...@gmail.com> wrote:
>
>> okay I have a candidate implementation based on the initial plugin on google
>> code.
> How big of a contribution is it? Does it need to go through the IP
> clearance process?
> http://incubator.apache.org/ip-clearance/index.html
>
--
Pablo Rodriguez Pina
Director
Anahata Technologies PTY LTD
Phone 04 1091 5078
E-mail pablo@anahata-it.com <ma...@anahata-it.com>
Web anahata-it.com <http://www.anahata-it.com>
Re: Include maven-car-plugin to the official maven plugins
Posted by Wendy Smoak <ws...@gmail.com>.
On Sat, Mar 19, 2011 at 4:19 PM, Stephane Nicoll
<st...@gmail.com> wrote:
> okay I have a candidate implementation based on the initial plugin on google
> code.
How big of a contribution is it? Does it need to go through the IP
clearance process?
http://incubator.apache.org/ip-clearance/index.html
--
Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
okay I have a candidate implementation based on the initial plugin on google
code.
Can someone with Jira admin right create the maven project for the plugin
please?
http://jira.codehaus.org/browse/MPA-116
Thanks,
Stéphane
On Sat, Mar 19, 2011 at 10:04 AM, Kristian Rosenvold <
kristian.rosenvold@gmail.com> wrote:
> Sorry, my misunderstanding.
>
> Looks good to me ;)
>
> Kristian
>
>
>
> lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
> > What other code are you talking about? The plugin on google code? The
> idea
> > here is to deprecate it in favor of this "official" maven plugin
> >
> > S.
> >
> > On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
> > kristian.rosenvold@gmail.com> wrote:
> >
> > > Just out of curiosity, how does this code relate to the other code that
> > > does similar stuff? Is it a copy paste fork?
> > >
> > > Kristian
> > >
> > > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
> > > > Hi,
> > > > No problem for me if you want to add this new packaging support and
> > > > add in maven core.
> > > >
> > > > acr ?
> > > >
> > > > --
> > > > Olivier
> > > >
> > > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
> > > > > No Maven committers/PMCs replied to this.
> > > > >
> > > > > Any insight?
> > > > >
> > > > > S.
> > > > >
> > > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> > > > > <st...@gmail.com>wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> I am currently working on supporting the "application-client"
> artifact
> > > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
> > > > >> maven-car-plugin[1] which is very similar to the EJB plugin but
> for
> > > > >> application-client type. Do we think it would be reasonable to add
> > > > >> this plugin to the portfolio of standard plugins? (if Pablo
> accepts to
> > > > >> contribute it to the ASF but I don't think it would be an issue).
> > > > >>
> > > > >> I am bit puzzled about the type 'car' since car is already used by
> > > > >> Geronimo for their deployment plans;
> <type>application-client</type>
> > > > >> would better fit I'd say (with a .jar extension)
> > > > >>
> > > > >> The problems I am having is that since we don't have an "official"
> > > > >> maven type for that thing and nothing to build it with Maven, I
> can't
> > > > >> detect these artifacts other than scanning every single jar file
> added
> > > > >> to a project to see if there is a META-INF/application-client.xml
> > > > >> file. Frankly, I am not going to implement a feature that will
> scan
> > > > >> every single jar file before building an EAR
> > > > >>
> > > > >> The plugin needs a bit of cleanup (namely the jEE version check)
> and I
> > > > >> don't know if the community uses this a lot but we don't cover the
> > > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much to
> do
> > > > >> it.
> > > > >>
> > > > >> Can someone remind me how these "official" types gets added and
> > > > >> detected by Maven? Do we absolutely need to touch the core type
> > > > >> definition files or is there another way?
> > > > >>
> > > > >> Please let me know what you think.
> > > > >>
> > > > >> Thanks,
> > > > >> S.
> > > > >>
> > > > >> [1] http://code.google.com/p/maven-car-plugin
> > > > >>
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Kristian Rosenvold <kr...@gmail.com>.
Sorry, my misunderstanding.
Looks good to me ;)
Kristian
lø., 19.03.2011 kl. 09.51 +0100, skrev Stephane Nicoll:
> What other code are you talking about? The plugin on google code? The idea
> here is to deprecate it in favor of this "official" maven plugin
>
> S.
>
> On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
> kristian.rosenvold@gmail.com> wrote:
>
> > Just out of curiosity, how does this code relate to the other code that
> > does similar stuff? Is it a copy paste fork?
> >
> > Kristian
> >
> > lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
> > > Hi,
> > > No problem for me if you want to add this new packaging support and
> > > add in maven core.
> > >
> > > acr ?
> > >
> > > --
> > > Olivier
> > >
> > > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
> > > > No Maven committers/PMCs replied to this.
> > > >
> > > > Any insight?
> > > >
> > > > S.
> > > >
> > > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> > > > <st...@gmail.com>wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> I am currently working on supporting the "application-client" artifact
> > > >> type properly in the EAR plugin. Pablo (in CC) wrote a
> > > >> maven-car-plugin[1] which is very similar to the EJB plugin but for
> > > >> application-client type. Do we think it would be reasonable to add
> > > >> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> > > >> contribute it to the ASF but I don't think it would be an issue).
> > > >>
> > > >> I am bit puzzled about the type 'car' since car is already used by
> > > >> Geronimo for their deployment plans; <type>application-client</type>
> > > >> would better fit I'd say (with a .jar extension)
> > > >>
> > > >> The problems I am having is that since we don't have an "official"
> > > >> maven type for that thing and nothing to build it with Maven, I can't
> > > >> detect these artifacts other than scanning every single jar file added
> > > >> to a project to see if there is a META-INF/application-client.xml
> > > >> file. Frankly, I am not going to implement a feature that will scan
> > > >> every single jar file before building an EAR
> > > >>
> > > >> The plugin needs a bit of cleanup (namely the jEE version check) and I
> > > >> don't know if the community uses this a lot but we don't cover the
> > > >> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> > > >> it.
> > > >>
> > > >> Can someone remind me how these "official" types gets added and
> > > >> detected by Maven? Do we absolutely need to touch the core type
> > > >> definition files or is there another way?
> > > >>
> > > >> Please let me know what you think.
> > > >>
> > > >> Thanks,
> > > >> S.
> > > >>
> > > >> [1] http://code.google.com/p/maven-car-plugin
> > > >>
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
What other code are you talking about? The plugin on google code? The idea
here is to deprecate it in favor of this "official" maven plugin
S.
On Sat, Mar 19, 2011 at 9:49 AM, Kristian Rosenvold <
kristian.rosenvold@gmail.com> wrote:
> Just out of curiosity, how does this code relate to the other code that
> does similar stuff? Is it a copy paste fork?
>
> Kristian
>
> lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
> > Hi,
> > No problem for me if you want to add this new packaging support and
> > add in maven core.
> >
> > acr ?
> >
> > --
> > Olivier
> >
> > 2011/3/19 Stephane Nicoll <st...@gmail.com>:
> > > No Maven committers/PMCs replied to this.
> > >
> > > Any insight?
> > >
> > > S.
> > >
> > > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> > > <st...@gmail.com>wrote:
> > >
> > >> Hi,
> > >>
> > >> I am currently working on supporting the "application-client" artifact
> > >> type properly in the EAR plugin. Pablo (in CC) wrote a
> > >> maven-car-plugin[1] which is very similar to the EJB plugin but for
> > >> application-client type. Do we think it would be reasonable to add
> > >> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> > >> contribute it to the ASF but I don't think it would be an issue).
> > >>
> > >> I am bit puzzled about the type 'car' since car is already used by
> > >> Geronimo for their deployment plans; <type>application-client</type>
> > >> would better fit I'd say (with a .jar extension)
> > >>
> > >> The problems I am having is that since we don't have an "official"
> > >> maven type for that thing and nothing to build it with Maven, I can't
> > >> detect these artifacts other than scanning every single jar file added
> > >> to a project to see if there is a META-INF/application-client.xml
> > >> file. Frankly, I am not going to implement a feature that will scan
> > >> every single jar file before building an EAR
> > >>
> > >> The plugin needs a bit of cleanup (namely the jEE version check) and I
> > >> don't know if the community uses this a lot but we don't cover the
> > >> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> > >> it.
> > >>
> > >> Can someone remind me how these "official" types gets added and
> > >> detected by Maven? Do we absolutely need to touch the core type
> > >> definition files or is there another way?
> > >>
> > >> Please let me know what you think.
> > >>
> > >> Thanks,
> > >> S.
> > >>
> > >> [1] http://code.google.com/p/maven-car-plugin
> > >>
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Include maven-car-plugin to the official maven plugins
Posted by Kristian Rosenvold <kr...@gmail.com>.
Just out of curiosity, how does this code relate to the other code that
does similar stuff? Is it a copy paste fork?
Kristian
lø., 19.03.2011 kl. 09.42 +0100, skrev Olivier Lamy:
> Hi,
> No problem for me if you want to add this new packaging support and
> add in maven core.
>
> acr ?
>
> --
> Olivier
>
> 2011/3/19 Stephane Nicoll <st...@gmail.com>:
> > No Maven committers/PMCs replied to this.
> >
> > Any insight?
> >
> > S.
> >
> > On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> > <st...@gmail.com>wrote:
> >
> >> Hi,
> >>
> >> I am currently working on supporting the "application-client" artifact
> >> type properly in the EAR plugin. Pablo (in CC) wrote a
> >> maven-car-plugin[1] which is very similar to the EJB plugin but for
> >> application-client type. Do we think it would be reasonable to add
> >> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> >> contribute it to the ASF but I don't think it would be an issue).
> >>
> >> I am bit puzzled about the type 'car' since car is already used by
> >> Geronimo for their deployment plans; <type>application-client</type>
> >> would better fit I'd say (with a .jar extension)
> >>
> >> The problems I am having is that since we don't have an "official"
> >> maven type for that thing and nothing to build it with Maven, I can't
> >> detect these artifacts other than scanning every single jar file added
> >> to a project to see if there is a META-INF/application-client.xml
> >> file. Frankly, I am not going to implement a feature that will scan
> >> every single jar file before building an EAR
> >>
> >> The plugin needs a bit of cleanup (namely the jEE version check) and I
> >> don't know if the community uses this a lot but we don't cover the
> >> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> >> it.
> >>
> >> Can someone remind me how these "official" types gets added and
> >> detected by Maven? Do we absolutely need to touch the core type
> >> definition files or is there another way?
> >>
> >> Please let me know what you think.
> >>
> >> Thanks,
> >> S.
> >>
> >> [1] http://code.google.com/p/maven-car-plugin
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Olivier Lamy <ol...@apache.org>.
Hi,
No problem for me if you want to add this new packaging support and
add in maven core.
acr ?
--
Olivier
2011/3/19 Stephane Nicoll <st...@gmail.com>:
> No Maven committers/PMCs replied to this.
>
> Any insight?
>
> S.
>
> On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
> <st...@gmail.com>wrote:
>
>> Hi,
>>
>> I am currently working on supporting the "application-client" artifact
>> type properly in the EAR plugin. Pablo (in CC) wrote a
>> maven-car-plugin[1] which is very similar to the EJB plugin but for
>> application-client type. Do we think it would be reasonable to add
>> this plugin to the portfolio of standard plugins? (if Pablo accepts to
>> contribute it to the ASF but I don't think it would be an issue).
>>
>> I am bit puzzled about the type 'car' since car is already used by
>> Geronimo for their deployment plans; <type>application-client</type>
>> would better fit I'd say (with a .jar extension)
>>
>> The problems I am having is that since we don't have an "official"
>> maven type for that thing and nothing to build it with Maven, I can't
>> detect these artifacts other than scanning every single jar file added
>> to a project to see if there is a META-INF/application-client.xml
>> file. Frankly, I am not going to implement a feature that will scan
>> every single jar file before building an EAR
>>
>> The plugin needs a bit of cleanup (namely the jEE version check) and I
>> don't know if the community uses this a lot but we don't cover the
>> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
>> it.
>>
>> Can someone remind me how these "official" types gets added and
>> detected by Maven? Do we absolutely need to touch the core type
>> definition files or is there another way?
>>
>> Please let me know what you think.
>>
>> Thanks,
>> S.
>>
>> [1] http://code.google.com/p/maven-car-plugin
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Include maven-car-plugin to the official maven plugins
Posted by Stephane Nicoll <st...@gmail.com>.
No Maven committers/PMCs replied to this.
Any insight?
S.
On Mon, Mar 14, 2011 at 9:22 AM, Stephane Nicoll
<st...@gmail.com>wrote:
> Hi,
>
> I am currently working on supporting the "application-client" artifact
> type properly in the EAR plugin. Pablo (in CC) wrote a
> maven-car-plugin[1] which is very similar to the EJB plugin but for
> application-client type. Do we think it would be reasonable to add
> this plugin to the portfolio of standard plugins? (if Pablo accepts to
> contribute it to the ASF but I don't think it would be an issue).
>
> I am bit puzzled about the type 'car' since car is already used by
> Geronimo for their deployment plans; <type>application-client</type>
> would better fit I'd say (with a .jar extension)
>
> The problems I am having is that since we don't have an "official"
> maven type for that thing and nothing to build it with Maven, I can't
> detect these artifacts other than scanning every single jar file added
> to a project to see if there is a META-INF/application-client.xml
> file. Frankly, I am not going to implement a feature that will scan
> every single jar file before building an EAR
>
> The plugin needs a bit of cleanup (namely the jEE version check) and I
> don't know if the community uses this a lot but we don't cover the
> whole spectrum of the JavaEE spec and it wouldn't cost us much to do
> it.
>
> Can someone remind me how these "official" types gets added and
> detected by Maven? Do we absolutely need to touch the core type
> definition files or is there another way?
>
> Please let me know what you think.
>
> Thanks,
> S.
>
> [1] http://code.google.com/p/maven-car-plugin
>