You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/06 08:50:29 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8032: fs/vfs: add missed truncate callback at timerfd file_operation

pkarashchenko commented on code in PR #8032:
URL: https://github.com/apache/nuttx/pull/8032#discussion_r1063246453


##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,6 +111,8 @@ static const struct file_operations g_timerfd_fops =
   NULL,          /* write */
   NULL,          /* seek */
   NULL,          /* ioctl */
+  NULL,          /* truncate */

Review Comment:
   Please reorder comments. mmap before truncate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org