You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2009/04/16 11:46:15 UTC

[jira] Commented: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

    [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699605#action_12699605 ] 

Regis Xu commented on HARMONY-6107:
-----------------------------------

I'm aware that patch HARMONY-6107v2.diff removed one test method, testAbstractMethods in PreferencesTest.java, do you think all the cases in this method could be covered by others? Or is it possible to add more "assert" to make the test more useful?

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.