You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2020/02/18 10:18:02 UTC
[GitHub] [dubbo] beiwei30 opened pull request #5757: register stated
url to provider model,
no matter the provider is configured to delay-published or not
## What is the purpose of the change
to make sure stated url on provider model always correct.
## Brief changelog
register stated url to provider model, no matter the provider is configured to delay-published or not.
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5757: register stated
url to provider model,
no matter the provider is configured to delay-published or not
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=h1) Report
> Merging [#5757](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/122c56d9fbef1a5b5de717f7bc202851c3a97a3b?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `60.2%`.
[](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5757 +/- ##
============================================
- Coverage 61.39% 61.19% -0.21%
- Complexity 496 497 +1
============================================
Files 980 981 +1
Lines 38829 39144 +315
Branches 5568 5644 +76
============================================
+ Hits 23841 23956 +115
- Misses 12363 12557 +194
- Partials 2625 2631 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `91.17% <ø> (+2.94%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVnaXN0cnlDb25maWcuamF2YQ==) | `87.59% <ø> (-0.1%)` | `0 <0> (ø)` | |
| [...pache/dubbo/config/spring/util/DubboBeanUtils.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9EdWJib0JlYW5VdGlscy5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==) | `79.16% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNsaWVudC5qYXZh) | `58.46% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [.../metadata/store/RemoteWritableMetadataService.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9zdG9yZS9SZW1vdGVXcml0YWJsZU1ldGFkYXRhU2VydmljZS5qYXZh) | `77.31% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/rpc/Invocation.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9JbnZvY2F0aW9uLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...nfig/bootstrap/builders/MetadataReportBuilder.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvYnVpbGRlcnMvTWV0YWRhdGFSZXBvcnRCdWlsZGVyLmphdmE=) | `97.36% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `23.1% <ø> (+0.16%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [131 more](https://codecov.io/gh/apache/dubbo/pull/5757/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=footer). Last update [122c56d...de64f79](https://codecov.io/gh/apache/dubbo/pull/5757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org